news icon indicating copy to clipboard operation
news copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

add: move feed dialog

Open pbek opened this issue 1 year ago • 1 comments

Summary

  • Add support for moving feeds to another folder from the sidebar feed menu

Checklist

pbek avatar Jun 25 '24 17:06 pbek

Ready for review...

pbek avatar Jun 26 '24 20:06 pbek

Do you still need something for this PR to be merged?

pbek avatar Jul 01 '24 18:07 pbek

No just the GitHub app says there is a merge conflict.

I would usually fix it myself or check what's wrong but in the app I can't see and I'm too busy with my normal job to spend much time on News lately.

Grotax avatar Jul 01 '24 21:07 Grotax

No just the GitHub app says there is a merge conflict.

I would usually fix it myself or check what's wrong but in the app I can't see and I'm too busy with my normal job to spend much time on News lately.

Oh, sorry. For some reason I didn't see that reply or I would have looked into it 😳 Thank you!

pbek avatar Jul 07 '24 12:07 pbek

@pbek my NextCloud instance is configured with de_DE locale and the menu entry for the move action seems to have a placeholder text. Can you give me a pointer how to fix that? I can see that the relevant entry seems to be present in the de_DE translation file here: https://github.com/nextcloud/news/blob/master/l10n/de_DE.js#L51-L52

@Grotax I think this can now be marked completed in https://github.com/nextcloud/news/issues/2503

britter avatar Sep 12 '24 07:09 britter

@pbek my NextCloud instance is configured with de_DE locale and the menu entry for the move action seems to have a placeholder text. Can you give me a pointer how to fix that? I can see that the relevant entry seems to be present in the de_DE translation file here: https://github.com/nextcloud/news/blob/master/l10n/de_DE.js#L51-L52

Which piece of code are we talking about?

pbek avatar Sep 12 '24 08:09 pbek

Hey @pbek! I'm not sure. I think it's this line. When running NextCloud in de_DE local what I see in the UI is:

Screenshot 2024-09-13 at 08 53 49

But that should really be "Feed in Ordner verschieben" according to the translation file I shared above. So I'm now trying to understand how translations are referenced from the component in order to fix this.

britter avatar Sep 13 '24 06:09 britter

I took the whole NcSelect from https://github.com/nextcloud/news/blob/69efa109249d5acfff016c5dab3493bc7eea2447/src/components/AddFeed.vue#L27 and didn't look the untranslated label. 😅

I'd say, they both need something like {{ t("news", "Folder name") }} instead of name.

pbek avatar Sep 13 '24 17:09 pbek