news icon indicating copy to clipboard operation
news copied to clipboard

Keyboard schortcuts stopped working

Open enaut opened this issue 1 year ago • 5 comments

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • [x] I have read the CONTRIBUTING.md and followed the provided tips
  • [x] I accept that the issue will be closed without comment if I do not check here
  • [x] I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

What problem did you encounter?

I used to use j,k,l keys for reading it stopped to work

Steps to Reproduce

Explain what you did to encounter the issue while reading pres j - it does not jump to the next message.

System Information

  • News app version: 25.0.0-alpha2
  • Nextcloud version: 28.0.0 beta 3
  • Browser and version: Firefox and Chrome
  • OS and version: Linux Fedora

enaut avatar Dec 01 '23 11:12 enaut

This is correct, the alpha is not feature complete yet.

SMillerDev avatar Dec 01 '23 11:12 SMillerDev

@SMillerDev, what would be a good starting point if someone would want to work on that feature?

pbek avatar May 01 '24 12:05 pbek

Probably the existing code, the old code and some other apps that have keyboard shortcuts. I have no real idea how to do this either (otherwise I would have)

SMillerDev avatar May 01 '24 12:05 SMillerDev

Thank you, I haven't researched yet on how to do it the "Vue.js way". 😉

pbek avatar May 01 '24 12:05 pbek

I found https://rogeriotaques.github.io/vue-hotkeys-rt/, but it needs Ctrl/CMD. So maybe just using @keyup on something, like <input @keyup.a="onPressA" />. 🤔

pbek avatar May 08 '24 07:05 pbek

Hey, while I have no Idea about php I found this: https://www.npmjs.com/package/vue-shortkey which seems to do what you want?

enaut avatar May 21 '24 12:05 enaut

Looks good too, thank you.

pbek avatar May 21 '24 17:05 pbek

@Grotax, I also tried to get a "reload" r shortcut working again, but still wasn't able to figure out how to properly reload the current item list. I've tried several things, e.g. in https://github.com/pbek/nextcloud-news/commit/d05e10e3f81a00cabc8a858bc017b407f0e957cc... Any hints?

pbek avatar Jul 01 '24 18:07 pbek

No how should I know since I started working on News in 2019 I haven't touched the frontend code in any meaningful way.

Already before that it was heavily unmaintained and deprecated.

That is why I asked in the forum for a frontend maintainer. Some to look after the frontend code and to review PRs and stuff...

But so far no reply

Grotax avatar Jul 01 '24 21:07 Grotax

Thank you, then I'll try to find a workaround. 😊

pbek avatar Jul 02 '24 05:07 pbek

just wanted to say thank you to you both @pbek and @Grotax

unfortunately I cannot really code at all but if there is something I could help with let me know please

john-2000 avatar Jul 02 '24 06:07 john-2000

Thank you very much!

pbek avatar Jul 02 '24 06:07 pbek