news icon indicating copy to clipboard operation
news copied to clipboard

Frontend is outdated

Open BernhardPosselt opened this issue 8 years ago • 20 comments

The frontend is outdated in various ways and is therefore way harder to maintain then needed:

  • Building the js bundle should be done with a few lines of webpack
  • After webpack is set up we can move to modularizing the code and use es6 module loading
  • Minification should be done with babili since uglifyjs doesnt work with anything remotely ES6 nor newer
  • Thirdparty libs should be pulled in entire from npm
  • Frontend should probably be migrated to a newer Angular or different technology

For an example webpack file with typescript see https://github.com/nextcloud/appstore/blob/master/webpack.config.js and https://github.com/nextcloud/appstore/blob/master/karma.conf.js for integration with karma


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

BernhardPosselt avatar Jun 15 '17 13:06 BernhardPosselt

Thirdparty libs should be pulled in entire from npm

Was actually already working on that. Just opened #197 to move all dependencies to npm and remove bower.

schaal avatar Jun 16 '17 13:06 schaal

In the calendar we are currently considering migrating to Vue.js

georgehrke avatar Oct 28 '17 16:10 georgehrke

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 31 '18 19:07 stale[bot]

@georgehrke did anything ever come of that?

SMillerDev avatar Aug 01 '18 06:08 SMillerDev

Some apps are already migrated to Vue. On my personal todo list I have a task trying to rewrite the frontend with Vue.js, but don't know when I'm able to start. In general I would like to see a new maintainable frontend. :grinning:

danopz avatar Aug 01 '18 07:08 danopz

@SMillerDev Not yet, but @skjnldsv is already working on migrating the Contacts app to Vue.js. We will do the same for the Calendar app once we successfully moved the Contacts app.

georgehrke avatar Aug 01 '18 07:08 georgehrke

@danopz We already have a lot of components ready-to-use for vue. If you want to upgrade the news app, we'll help you with a great joy ;)

skjnldsv avatar Aug 01 '18 07:08 skjnldsv

I would be glad to help migrating this app to vue.js.

I migrated the flowupload app to vue (from angular) a month ago (the frontend of this app is obviously more complicated)

JonathanTreffler avatar Jun 09 '20 14:06 JonathanTreffler

@Grotax @JonathanTreffler @schaal @SMillerDev @danopz @BernhardPosselt we have a Nextcloud Talk instance also with e.g. a channel for Vue discussions, as well as a "News team" channel – it’s not very active yet but we do have @David-Development @stefan-niedermann and @phedlund already in! :)

I can add you there with your email address and name if you like, then you can disuss about updating it to the Vue components?

jancborchardt avatar Jul 31 '20 13:07 jancborchardt

And another thing: We are working on a new "Dashboard" at the moment and it would be quite cool if there would be a News app widget for it? :slightly_smiling_face: – see details at https://github.com/nextcloud/server/issues/20930

jancborchardt avatar Jul 31 '20 13:07 jancborchardt

Pull requests are welcome 🤷‍♂️

SMillerDev avatar Jul 31 '20 13:07 SMillerDev

I can add you there with your email address and name if you like, then you can disuss about updating it to the Vue components?

My email adress is [email protected] 😀

JonathanTreffler avatar Jul 31 '20 17:07 JonathanTreffler

@SMillerDev @Grotax (and others) should I also add you? :)

jancborchardt avatar Aug 03 '20 21:08 jancborchardt

@SMillerDev @Grotax (and others) should I also add you? :)

I'm not really gonna spend any time on the vue migration, but if you want you can invite me with <username>@me.com

SMillerDev avatar Aug 04 '20 07:08 SMillerDev

Yea sure but I'm not very active at the moment [email protected]

Grotax avatar Aug 04 '20 07:08 Grotax

I can add you there with your email address and name if you like, then you can disuss about updating it to the Vue components?

How can we get access ? Is it the instance at cloud.nextcloud.com ?

JonathanTreffler avatar Aug 06 '20 22:08 JonathanTreffler

Just invited the 3 of you, you should get an invitation mail. :) Yes it is the instance at cloud.nextcloud.com – and you will also be able to e.g. use the mobile apps for convenience. (You can change your names and also set avatars, but file upload is restricted for guest users.)

jancborchardt avatar Aug 06 '20 22:08 jancborchardt

(i changed my github username to JonathanTreffler and updated comments mentioning my old username. I wanted to change it for a while and the number of mentions i then need to update only increases)

JonathanTreffler avatar Aug 07 '20 07:08 JonathanTreffler

The Angular version of news will only be supported until end of 2021.

Grotax avatar Sep 21 '21 11:09 Grotax

I updated the admin page to vue here https://github.com/nextcloud/news/pull/1880 , would be great if someone could give it a review

CarlSchwan avatar Aug 24 '22 22:08 CarlSchwan

It looks like the frontend is updated to vue as well in v18.2.0

meichthys avatar Sep 28 '22 15:09 meichthys

The admin settings are but nothing else is.

SMillerDev avatar Sep 28 '22 15:09 SMillerDev

Sorry if I post this here on the wrong place but I was thinking about contributing to the vue rewrite but it's getting a bit messy here with all the branches and PRs. Which one is the most promising/recent one? And can we coordinate work on that?

powerpaul17 avatar Oct 21 '22 18:10 powerpaul17

@CarlSchwan migrated the admin settings to Vue js already that part is done. He also took the existing work and cleaned the code a bit, but didn't continue after that probably due to time constraints. You can find a PR with the changes.

@devlinjunker continued the work on the vue-rewrite branch, there are already some commits on that branch, you can find pull requests in his forked repository that are in progress.

That is the latest status.

Grotax avatar Oct 21 '22 20:10 Grotax

Are the forks by @CarlSchwan and @devlinjunker different? Is it clear at the moment which to contribute to?

rhyst avatar Oct 24 '22 10:10 rhyst

I can't really say. Both are quite in the beginning.

Probably best of you take a look at both and decide for yourself which is the better base to contribute to.

Grotax avatar Oct 25 '22 13:10 Grotax

Latest changes were done here: https://github.com/nextcloud/news/pull/1968

Grotax avatar Nov 02 '22 10:11 Grotax

Good evening 👋🏼

I see this has been ongoing for some time, I also see that some of the issues affected by this are still ongoing.

Is there any update on when a rewrite of the frontend will complete? An issue that was opened about date order was closed as the fix is a rewrite, but thats still in progress.

mhzawadi avatar Jan 25 '23 21:01 mhzawadi

It'll be done when it is done. You can't plan volunteer time and motivation.

SMillerDev avatar Jan 26 '23 07:01 SMillerDev

Hi.

I have been looking into this for personal use, and am open to volunteering on this myself.

Feel free to shoot me an email (excuse the alias address, will reply on regular ☺) : [email protected]

Have the opportunity to spend quite a bit of time volunteering for a good chunk of time - happy to send though experience, etc - however have experience in most tech mentioned above (php, js, vue). Full stack, but better in front end ☺.

scottdotau avatar Oct 02 '23 11:10 scottdotau