news-android icon indicating copy to clipboard operation
news-android copied to clipboard

fast action mark all as read and refresh

Open geeseven opened this issue 4 years ago • 6 comments

Greetings,

I am really enjoying the new fast action features. Thanks @emasty. I would like to request a 'mark all as read and refresh' option to go along with 'mark all as read'. Almost always, I want to refresh after marking all as read, so it would be super handy to have one button to do both actions.

geeseven avatar Aug 29 '20 20:08 geeseven

Thanks for your input! I'm just wondering if it wouldn't make sense to always trigger a refresh? Are there cases where this is not the expected behavior? @emasty what do you think about this idea?

David-Development avatar Sep 09 '20 18:09 David-Development

Hey @David-Development,

I was theory-crafting and came up with the following cons for replacing the 'mark all as read' with 'mark all as read and refresh':

  • Users wanting to extremely limit mobile data usage.
  • Users that live or visit areas with no wifi or mobile data. They would sync up in town then go though items where there is no service.

I am not sure how many users would fit these situations or if they are even a big deal.

Personal, I have a fair number of folders. Currently when I have numerous new articles, I go folder by folder and marking each folder as read as I go through them. Once that is complete, I do one big refresh. That being said, I am not apposed to replacing 'mark all as read' with 'mark all as read and refresh'.

geeseven avatar Sep 09 '20 22:09 geeseven

"Currently when I have numerous new articles, I go folder by folder and marking each folder as read as I go through them. Once that is complete, I do one big refresh."

If I understand you workflow correctly you would need "mark all as read and only refresh when all folders are read"?

"Mark all as read and refresh" could be easy to implement if it doesn't interfere with any async server calls. I would suggest to make it optional as it could destroy workflows. E.g. I want control over when to refresh and want to have a subscription cleared and not refreshed again. But I can see that different workflows could benefit from it.

"Mark all as read and refresh only if everything is read" is probably a bit harder to implement but mainly I feel it would be confusing and hard to understand for users. And in this case it also doesn't save you a lot of interaction compared to pull-to-refresh.

emasty avatar Sep 10 '20 07:09 emasty

Hey @emasty,

Thanks for the timely reply.

"Currently when I have numerous new articles, I go folder by folder and marking each folder as read as I go through them. Once that is complete, I do one big refresh."

If I understand you workflow correctly you would need "mark all as read and only refresh when all folders are read"?

No, sorry if I was not clear. I was describing that workflow as an example not to replace 'mark all as read' with 'mark all as read and refresh'.

My request has not changed. I would like to see an option for 'mark all as read and refresh' in addition to 'mark all as read'.

geeseven avatar Sep 10 '20 17:09 geeseven

I've had a short look today but couldn't find an easy way to access the refresh function but also don't want to just replicate it. I will have a closer look when the weather gets rainy - if it is not done by then ;)

Refresh function: https://github.com/nextcloud/news-android/blob/fae0e9d8288297a5ca1bc5854fcf6b8b7fbb579e/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java#L666

Has to be accessed here if corresponding setting (to be introduced) is set: https://github.com/nextcloud/news-android/blob/fae0e9d8288297a5ca1bc5854fcf6b8b7fbb579e/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java#L826-L833

emasty avatar Sep 19 '20 13:09 emasty

Hello all, would be great if this "Mark all as read" button can switch to the next feed with unread articles. Ready to contribute if there is any kind of bounty program :D. My use case is that I am reading articles feed by feed, and I am not finding any efficient way to do it with NC News. Thank you for your great job !

alxnbl avatar Nov 29 '20 06:11 alxnbl