neon
neon copied to clipboard
nextcloud
feat(ios): Added ios support to existing project
I have created the issue #754 and this is the PR however please let me know about the commit message I don't know if it's correct or not.
The part in the brackets should resemble the package you have changed.
At a quick glance looks like you should have use both app and neon, becoming something like:
feat(app,neon): initial iOS support
We also have sort of commit linting wich should have been activated by the ./tool/setup.sh script if run by you.
running dart run husky install would install it without running the setup script (although I don't see a reason not to run the script).
This will install a git hook to the local clone and whenever you commit the hook should be executed informing you whether you did it right (You mentioned to use a graphical git app. I don't know whether it supports this).
Finally please also signoff your commits. this can be done by using git commit -s (again might be different in a gui). The logs of the failed DCO check also talks you through that.
@nishp77 Can you make sure that your branch is rebased onto the latest main branch? I see a lot of changes that are already in our main branch (I'm not sure exactly why the show up here).
@nishp77 do you plan on continuing this? Do you need some help with it? Afaik @Leptopoda has access to a Mac now, so you two could work on it together.
I think the only thing missing was hooking it up to the icon generation script. Other than that I tested this PR on an iOS emulator and it was working just fine.
Once I have more time I'll test it on some physical iOS devices and test all of our functionality but other than the mentioned notifications issue this should be all.
When I checked out the PR I also noticed minor missing things like the package ID being wrong but that should also not be a big problem :)
Sorry guys got busy because I was away I will starting working back again on this...
I'm going to close this for now and keep the branch locally. It currently isn't our priority and I do not have the capacity to maintain iOS at this point of time.