maps icon indicating copy to clipboard operation
maps copied to clipboard

Restrict app to groups

Open szaimen opened this issue 5 years ago • 4 comments

I've searched for existing issues, but didn't found one, hence I opened this one.

Is your feature request related to a problem? Please describe. Hey, I would like to restrict some users to not be able to use the maps app.

Describe the solution you'd like I would like to be able to restrict the maps app to specific groups without using the guests app.

Describe alternatives you've considered Currently no idea

Additional context Here is a screenshot for the calendar app: image

There was a comparable problem with the contacts app. Maybe you could use the same fix for the maps app? https://github.com/nextcloud/contacts/pull/1938 https://github.com/nextcloud/contacts/issues/1937

Alternatively, the photos app is capable of requesting all files without having the filesystem type in its appinfo.xml https://github.com/nextcloud/photos/blob/master/appinfo/info.xml

szaimen avatar Nov 28 '20 14:11 szaimen

Maybe @eneiluj has an idea how to implement this? :)

szaimen avatar Nov 30 '20 11:11 szaimen

not sure if this is still valid or not https://docs.nextcloud.com/server/11.0/developer_manual/app/info.html#types so might be related to types section in appinfo/info.xml I tested in my test nextcloud instance the following:

  1. disabled maps
  2. removed the following lines in maps/appinfo/info.xml <types> <filesystem/> </types>
  3. enabled maps

as a result I was able to limit maps to groups maps_limit_to_group as far as I can see maps is still working as expected and is only available for users of testgroup. However I have not really any knowledge about the reason and result of the defined filesystem type in info.xml and also not knowledge about possible consequences if removing this type. I only tested it due to curiosity and wanted to share this observation.

wronny avatar Jan 12 '21 23:01 wronny

  1. disabled maps
  2. removed the following lines in maps/appinfo/info.xml <types> <filesystem/> </types>
  3. enabled maps

@eneiluj do you know if that has any bad side effects?

szaimen avatar Jan 12 '21 23:01 szaimen

According to latest documentation for info.xml https://nextcloudappstore.readthedocs.io/en/latest/developer.html#info-xml seams not to be a valid xml-elements!

deflektor-de avatar Oct 22 '21 17:10 deflektor-de

I can confirm that this is broken when installing the plugin on NextCloud 24 and that the fix above works to re-enable Group Restrictions.

normen avatar Nov 03 '22 21:11 normen

Duplicate of https://github.com/nextcloud/maps/issues/170

Thatoo avatar Feb 16 '23 09:02 Thatoo

Thanks for the fix! P.S. @tacruc - Arne is that you? Normen from Morsum here o_O

normen avatar Feb 17 '23 10:02 normen

not sure if this is still valid or not https://docs.nextcloud.com/server/11.0/developer_manual/app/info.html#types so might be related to types section in appinfo/info.xml I tested in my test nextcloud instance the following:

1. disabled maps

2. removed the following lines in maps/appinfo/info.xml
   `     <types> <filesystem/> </types>`

3. enabled maps

as a result I was able to limit maps to groups maps_limit_to_group as far as I can see maps is still working as expected and is only available for users of testgroup. However I have not really any knowledge about the reason and result of the defined filesystem type in info.xml and also not knowledge about possible consequences if removing this type. I only tested it due to curiosity and wanted to share this observation.

I can't say if it's a a security issue, but it still works for me on a NC 27.0.1, thanks a lot !

rodinux avatar Sep 28 '23 21:09 rodinux

I can't say if it's a a security issue, but it still works for me on a NC 27.0.1, thanks a lot !

Its not a security issue, afaik the issue is that if you do this then the background processing of data (image GPS data, GPS tracks etc.) won't be done.

normen avatar Sep 29 '23 13:09 normen