[blocked by core] don't get contacts from disabled address books

[julien-nc]

As mentioned in #169, contacts from disabled address books were showed on the map and suggested when placing contacts. Address book state is now verified from the database.

[jancborchardt]

@efelon can you check if this fixes the issue you reported at https://github.com/nextcloud/maps/issues/169 ? :)

[georgehrke]

Please note that you are ever only supposed to query ( or insert / update / delete ) tables that your app also created.

oc_properties is a private database table created by the dav app and may change at any time without prior notice.

Meaning, right now there is no officially supported API to get the enabled status of an addressbook in PHP. I created this issue and will try to look into it. https://github.com/nextcloud/server/issues/17537

[julien-nc]

@georgehrke Ok thanks for the feedback.

So we shouldn't merge that for now.

Now let's keep this sleeping until there is an official way to get address book states.

[efelon]

@jancborchardt in that case there is no need for me to test. I'm aware and will wait for a final solution.

Thanks anyway everyone for looking into it.

[RoBo-OnGitHub]

It seems to be a trivial feature request to hide disabled contacts from showing up in the map. For example if someone has an 'archive' address book. Meanwhile it should have been possible to get an 'API' agreement with the coders from the contacts app? Otherwise, I would hope that meanwhile we're stop waiting and implement the enable/disable state based on the oc_properties, taking the dependency for granted, while waiting for the API-agreement. As it's taking the functionality down big time. Hmm it seems that it's even coded about 3 years ago. Why wasn't it released?