maps icon indicating copy to clipboard operation
maps copied to clipboard

Make app compatible with NC32

Open rakekniven opened this issue 3 months ago • 12 comments

Actually the app is not listed as ready for NC32

rakekniven avatar Sep 26 '25 15:09 rakekniven

And I stumbled on this error when using it with NC 32: https://github.com/nextcloud/maps/issues/1469

tflidd avatar Oct 09 '25 08:10 tflidd

I hit this issue while sync calendar shared from one user to another. SSO login with OIDC (and many other actions) failed with "Undefined constant OCP\\Share::SHARE_TYPE_USER in file '/var/www/html/custom_apps/maps/lib/Hooks/FileHooks.php' line 154" - solved after disabling maps app

isdnfan avatar Oct 28 '25 21:10 isdnfan

Thank you @isdnfan one more reason for me, not to upgrade to NC32 yet

ant0nwax avatar Oct 29 '25 08:10 ant0nwax

Wir nutzen Nextcloud-AIO im Docker und hier wird zwar schon NC 32.0.2 angezeigt, wegen inkompatible Software ( Maps) geht das wohl aber noch nicht..., Bitte aktualisieren auf die Version 32. Habe auch schon versucht per Email kontakt aufzunehmen.

ricokulzk-dotcom avatar Nov 25 '25 09:11 ricokulzk-dotcom

Please give a thumbs up instead of "me too" or "+1" comments. Issues can be sorted by upvotes.

rakekniven avatar Nov 26 '25 07:11 rakekniven

Hi, the PR aiming to close this issue is ready for a month now -- is something holding back its being merged, and if so, how can we help? Thank you for your hard work

hayvan96 avatar Dec 06 '25 13:12 hayvan96

is something holding back its being merged, and if so, how can we help?

Yes, pull requests need to be tested and reviewed, you cannot just merge them without someone approving it.

tflidd avatar Dec 10 '25 12:12 tflidd

One of the issues is the lack of compatibility with php8.4.

RainerEmrich avatar Dec 11 '25 13:12 RainerEmrich

One of the issues is the lack of compatibility with php8.4.

Maps are not compatible with php8.4? Weird since for quite some time now I have php8.4 on my nextcloud which is on version 31, and maps work there very well.

Szwendacz99 avatar Dec 11 '25 13:12 Szwendacz99

One of the issues is the lack of compatibility with php8.4.

Maps are not compatible with php8.4? Weird since for quite some time now I have php8.4 on my nextcloud which is on version 31, and maps work there very well.

I have a NC32 instance runinng with the recommended php8.4. If you try to enable maps, you get a failure saying that it needs php version lower than 8.3!

RainerEmrich avatar Dec 11 '25 13:12 RainerEmrich

One of the issues is the lack of compatibility with php8.4.

Maps are not compatible with php8.4? Weird since for quite some time now I have php8.4 on my nextcloud which is on version 31, and maps work there very well.

I have a NC32 instance runinng with the recommended php8.4. If you try to enable maps, you get a failure saying that it needs php version lower than 8.3!

Actually, 8.4 is supported but 8.3 is still recommended. https://docs.nextcloud.com/server/stable/admin_manual/release_notes/upgrade_to_32.html

tuxArg avatar Dec 11 '25 13:12 tuxArg

One of the issues is the lack of compatibility with php8.4.

Maps are not compatible with php8.4? Weird since for quite some time now I have php8.4 on my nextcloud which is on version 31, and maps work there very well.

I have a NC32 instance runinng with the recommended php8.4. If you try to enable maps, you get a failure saying that it needs php version lower than 8.3!

Actually, 8.4 is supported but 8.3 is still recommended. https://docs.nextcloud.com/server/stable/admin_manual/release_notes/upgrade_to_32.html

You're right, my reading was for the upcoming NC33.

RainerEmrich avatar Dec 11 '25 14:12 RainerEmrich

is something holding back its being merged, and if so, how can we help?

Yes, pull requests need to be tested and reviewed, you cannot just merge them without someone approving it.

Thank you, I know that -- my point was that the suggested PR is now one month and a half long, so to rephrase, is something holding back its being reviewed in order to be merged?

hayvan96 avatar Dec 12 '25 08:12 hayvan96