maps icon indicating copy to clipboard operation
maps copied to clipboard

Support Nextcloud 30, update CSP header

Open Ma27 opened this issue 1 year ago • 2 comments

Closes #1333 It probably makes most sense to review this commit-by-commit.

cc @come-nc @susnux @tacruc

Ma27 avatar Oct 06 '24 14:10 Ma27

Btw I've seen that the CI failed because of a missing Signed-off-by, will fix it up on the next iteration.

Ma27 avatar Oct 07 '24 10:10 Ma27

cc @julien-nc I guess

AndyScherzinger avatar Oct 10 '24 17:10 AndyScherzinger

Hi @Ma27, Thanks a lot for your contribution I appreciate it a lot. Unfortunately I'm currently quite busy. Right now I'm sitting in a train and wanted to use the time to update and merge this. Unfortunately my laptop run out of battery and the plugs are not working. So I'm stuck with my phone.

Could you update the Test workflow such that the tests are run on NC30? https://github.com/nextcloud/maps/blob/master/.github/workflows/test.yml

tacruc avatar Nov 01 '24 06:11 tacruc

Hi @tacruc! No worries at all!

Pushed a commit that does that. Not sure if it's completely correct though, I usually work with other CI systems :upside_down_face: However, I think you should be able to push to my fork's branch as well, right?

Ma27 avatar Nov 01 '24 14:11 Ma27

Thanks a lot. In theory I should be able to push to your branch. In practice I didn't find a good git client for Android. Do you know one?

Can you remove v28 and v29 from testing and make the DCO, happy? I think then we can go for a merge.

tacruc avatar Nov 03 '24 06:11 tacruc

Done.

Ma27 avatar Nov 03 '24 10:11 Ma27

@Ma27, there is a nightly build with your PR https://apps.nextcloud.com/apps/maps

tacruc avatar Nov 03 '24 23:11 tacruc