feat: add recipient info on the right side of the composer

[GretaD]

fixes #9622

5cba586

[GretaD]

Hi @ShGKme we need your vue expertise to decide how to move on here.

we would like to find a way how to properly show info on the right pane, that should look more or less like the contact one (see mockup on the initial ticket). Duplicating code is not the right way to go for obvious reasons. Do you have any idea what would be best to do here? This feature has to go in on Thursday.

[ShGKme]

Hi @GretaD

This feature has to go in on Thursday.

Having this, I'd start with duplicating the code. Then you can do it faster. And also see what will be different, what customization or interface will be required.

Then, when it works, we should move it to a library. Either @nextcloud/vue or a new one.

Also, there could be two ways:

1. Reuse only UI components, but not the login with VCard queries
2. Reuse everything, like NcTeam* components do in @nextcloud/vue

I'd go with the second one. Not sure this component could be needed as a pure UI component.

[ChristophWurst]

The raw search query that works

<?xml version="1.0"?>
<x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
  <x0:prop xmlns:x0="DAV:">
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x0:displayname/>
    <x0:owner/>
    <x0:resourcetype/>
    <x0:sync-token/>
    <x0:current-user-privilege-set/>
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x4:address-data/>
  </x0:prop>
  <x4:filter test="allof">
    <x4:prop-filter name="EMAIL">
      <x1:text-match xmlns:x1="urn:ietf:params:xml:ns:carddav">[email protected]</x1:text-match>
    </x4:prop-filter>
  </x4:filter>
</x4:addressbook-query>

[ChristophWurst]

This change needs a counterpart in Contacts. Where can we find that change?

[GretaD]

This change needs a counterpart in Contacts. Where can we find that change?

the description was not updated recently, sorry about that, i added the info of the current state.

[GretaD]

I only see the email address in the right pane when having two recipients, no error in console

thanks so much for reviewing. i will wait for a second reviewer and deliver all in one fixup, <3

[kesselb]

• I'm not a fan of showing the sidebar when entering an email address / selecting a contact because it shifts the composer modal. What do you think about always showing the sidebar?
• It's possible to select a contact group as recipient. This will also trigger the xhr request to find the contact details. Could we add a check if recipient starts with "nextcloud:" then don't search the contact details? A possible enhancement for a follow-up could be to list the members of the group.

[kesselb]

• [x] Something weird happens when deleting a recipient with the contact picture:

Screencast From 2024-12-03 15-02-58.webm

[GretaD]

Tested. Works.

The only thing I would add is the ability to minimize the side pane. It takes up a lot of room and makes the email message area very small.

its there, if you click the minimaze/maximize button on top right :) you can remove it and continue with your composer only view

[SebastianKrupinski]

its there, if you click the minimaze/maximize button on top right :) you can remove it and continue with your composer only view

Ah. Okay, That might be a bit confusing. I thought that was to minimize the entire modal. Would be better to put a > icon in the top left corner of the pane. But that is up to design.