mail icon indicating copy to clipboard operation
mail copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Feat: phishing detection

Open hamza221 opened this issue 9 months ago • 1 comments

Ref https://github.com/nextcloud/mail/issues/9453

hamza221 avatar Apr 29 '24 12:04 hamza221

Great presentation today :+1:

Sorry, I didn't have the opportunity to review the pr.

  1. I'm uncertain about the reply-to warning. The purpose of reply-to is to send the response to a different email. I wonder if we want to use a less scary warning for such a case. For example, our calendar invitations are also using reply-to.

  2. The PhishingDetectionService reminds me a bit about our CheckSetupController in server. I think we could move every check to an own class. Testing is also easier than. Wdyt @ChristophWurst?

kesselb avatar May 28 '24 14:05 kesselb

codecov/project — 43.34% (-6.87%) compared to c6e28fd

could you check test coverage of new classes?

ChristophWurst avatar Jun 13 '24 12:06 ChristophWurst

codecov/project — 43.34% (-6.87%) compared to c6e28fd

could you check test coverage of new classes?

image

hamza221 avatar Jun 13 '24 13:06 hamza221

Can we go to 100? :)

ChristophWurst avatar Jun 13 '24 13:06 ChristophWurst

image

hamza221 avatar Jun 27 '24 01:06 hamza221