mail icon indicating copy to clipboard operation
mail copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Fix: misplaced border ncselect

Open hamza221 opened this issue 11 months ago • 9 comments

Fix #9445

b a
image image

hamza221 avatar Mar 21 '24 14:03 hamza221

i thought the issue was that the dropdown not having a top border.

GretaD avatar Mar 21 '24 14:03 GretaD

i thought the issue was that the dropdown not having a top border.

Yes, I realised that later after checking pre-vue8 , that's why I turned it into draft

Pre vue8 there was no border and no slot for no results

hamza221 avatar Mar 21 '24 15:03 hamza221

pre vue-8 image

hamza221 avatar Mar 21 '24 15:03 hamza221

I left the No result in image

hamza221 avatar Mar 21 '24 15:03 hamza221

/backport to stable3.6

ChristophWurst avatar Apr 11 '24 09:04 ChristophWurst

PHP-CS unrelate to this PR, might be cause by this https://github.com/nextcloud/mail/commit/7af56c9347bd79df724058c466505798af382938

hamza221 avatar Apr 11 '24 10:04 hamza221

https://github.com/nextcloud/mail/pull/9552

ChristophWurst avatar Apr 11 '24 10:04 ChristophWurst

The borderless design does not look very appealing. Could we fully switch to the default ncselect styling with borders? We have bordered and stacked inputs in other places too: image

So I guess it would be fine to also have the borders in the Mail composer. @jancborchardt objections? if so, please provide mockups for a borderless select component

ChristophWurst avatar Apr 19 '24 09:04 ChristophWurst

@nextcloud/designers any suggestions?

hamza221 avatar May 17 '24 10:05 hamza221