mail icon indicating copy to clipboard operation
mail copied to clipboard

fix no sent mailbox configured

Open hamza221 opened this issue 2 years ago • 7 comments

Fix #4153 Repro:

  1. remove the default folder for sent ("you can do it in vuex by setting sentMailboxId to null")
  2. Try to send a message

Fix: Ps: Other ideas are appreciated

  1. Check if a mailbox named Sent or equivalent in the local language
  • if it exists set it as Sent default folder and resend message, if not:
  1. create a new mailbox
  2. set it as send default folder
  3. resend the message
  4. Catch exceptions and inform the user with toasts accordingly

hamza221 avatar Mar 28 '23 23:03 hamza221

Where exactly do you set sentMailboxId to null? (I can't get the error reproduced)

JohannesGGE avatar Jul 07 '23 09:07 JohannesGGE

Where exactly do you set sentMailboxId to null? (I can't get the error reproduced)

I do it in the vue.js devtools browser extension

hamza221 avatar Jul 19 '23 16:07 hamza221

The changes feel a bit too complex and messy. I think we should try to find a cleaner, less complicated spot to place the logic. I'll think about an alternative.

How about we just move the logic into the head of NewMessageModal::onSend? We have access to the accountId and can fetch the account, check for the mailbox existence and act, then proceed with the usual send logic.

The good news is that this isn't too far off the current state. The code just has to be pushed around a bit.

I also think we don't necessarily need a special loading text for this state. For the user it's sufficient if we show Sending … while creating/assigning the mailbox

ChristophWurst avatar Sep 13 '23 09:09 ChristophWurst

Creating a new mailbox is not tested, not sure how to without an account

hamza221 avatar Mar 17 '25 11:03 hamza221

Works, but not as expected.

Bildschirmfoto vom 2025-05-16 13-28-28

I see this chain of toasts, so the logic kicks in.

Bildschirmfoto vom 2025-05-16 13-29-15

But my sent mailbox is now set to nullSent. Which is not just a UI glitch, it created this mailbox:

image

The creation shouldn't even happen, because I do have a mailbox named Sent and it does have the \sent attribute:

image

ChristophWurst avatar May 16 '25 11:05 ChristophWurst

It fails to detect my existing mailbox Sent and runs into a HTTP400. The toasts are honestly overwhelming and confusing.

First I get this Bildschirmfoto vom 2025-05-27 09-52-22

Bildschirmfoto vom 2025-05-27 09-52-25

image

The message is sent and stored in my mailbox called "Sent", nevertheless?!

ChristophWurst avatar May 27 '25 07:05 ChristophWurst

It fails to detect my existing mailbox Sent and runs into a HTTP400. The toasts are honestly overwhelming and confusing.

First I get this Bildschirmfoto vom 2025-05-27 09-52-22

Bildschirmfoto vom 2025-05-27 09-52-25

image

The message is sent and stored in my mailbox called "Sent", nevertheless?!

Toasts were all over the place, It should make sense now, I added early returns and removed extra Toasts

hamza221 avatar Jun 05 '25 11:06 hamza221