mail icon indicating copy to clipboard operation
mail copied to clipboard

fix: bring back too many recipients check

Open miaulalala opened this issue 3 years ago • 5 comments

Needs https://github.com/nextcloud/mail/pull/9364

Fixes #6461

miaulalala avatar Sep 23 '22 14:09 miaulalala

Anything missing except tests?

ChristophWurst avatar Sep 29 '23 09:09 ChristophWurst

Anything missing except tests?

added tests

miaulalala avatar Oct 09 '23 16:10 miaulalala

This checks for individuals but not expanded groups, right? As far as I can see we only expand at \OCA\Mail\Service\MailTransmission::sendLocalMessage so there is no warning for sending a message to one group of 1000 people.

ChristophWurst avatar Oct 09 '23 16:10 ChristophWurst

This checks for individuals but not expanded groups, right? As far as I can see we only expand at \OCA\Mail\Service\MailTransmission::sendLocalMessage so there is no warning for sending a message to one group of 1000 people.

That's true - I will add it.

miaulalala avatar Oct 10 '23 07:10 miaulalala

Needs https://github.com/nextcloud/mail/pull/9364

We already have a recipients check but it depends on the Anti Abuse Protection to be turned on.

We can move the recipients check to be before we check for that to be enabled. Still needs the outbox status bc the exception won't bubble up so the mail will be sent regardless.

To Do:

Check if the recipient warning also expands groups (I don't think so), also needs a force option to send regardless.

miaulalala avatar Feb 26 '24 10:02 miaulalala

Not worth rebasing.

miaulalala avatar Jul 23 '24 11:07 miaulalala