mail
mail copied to clipboard
nextcloud
Change the 'show image' styling
this is how i tried to make it work with the state of actions we have now. But i agree with Marco's comment here: https://github.com/nextcloud/mail/issues/6122#issuecomment-1202480324
before
after
- [ ] Requires https://github.com/nextcloud/nextcloud-vue/pull/2911
@jancborchardt and @nimishavijay please have a look at this solution and if you're ok with it
[ ] "Show image" → "Show images"
[ ] The eye icon is not necessary, as per mockup
[ ] In the menu, the icons are all the same, so either we should go with no icons or:
- Temporarily: https://fonts.google.com/icons?selected=Material%20Icons%3Aimage%3A
- Show from this email: https://fonts.google.com/icons?selected=Material%20Icons%3Amail%3A
- Show from this domain: https://fonts.google.com/icons?selected=Material%20Icons%3Adomain%3A
Regarding the comment from @marcoambrosini, either is fine with me. Indeed using the tertiary button component would be more accurate since it’s not a link which goes somewhere.
all the point can be delivered but the icon one. The action must have an icon, it cannot be removed unfortunately, sorry should have commented that before. If we wait for the vue changes, this will be delivered a bit late, if we move on with my solution, it will look like this(plus your comments, but with an icon)
@GretaD cool, and fine for now with the icon too, but then also use the "image" filetype icon instead of "eye".
We can definitely add the option not to have an icon and have the menus triggered by tex-tonly buttons. I think it totally makes sense.
...and that will automatically be the case when https://github.com/nextcloud/nextcloud-vue/issues/2768 happens
We can definitely add the option not to have an icon and have the menus triggered by tex-tonly buttons. I think it totally makes sense.
i know that, but when it is going to be released? :)
pr is there https://github.com/nextcloud/nextcloud-vue/pull/2911#issuecomment-1207891395 Let's wait for more reviewers since it's a big change. Also you can review @GretaD :)
Once that's we can do a minor release
How is this unblocked when it depends on https://github.com/nextcloud/nextcloud-vue/pull/2911 and this app still uses v5?
How is this unblocked when it depends on nextcloud/nextcloud-vue#2911 and this app still uses v5?
ah sorry didnt see you added the component on desc. I am not using that component, that was not related to actions without icons, what Marco meant(double checked with him) is that after that is in, we can edit the actions on vue again and add a slot with no icons, but as you i thought that that was supposed to be done on the same pr,
What i did here was hiding the icon with display none. I dont have time to spend on the component now, so we can either do this or wait till we have time.