mail icon indicating copy to clipboard operation
mail copied to clipboard

Change mail logo to material design icon

Open GretaD opened this issue 3 years ago • 3 comments

To do

  • [x] Change all the mail icons to img folder
  • [ ] Attribution

Fixes https://github.com/nextcloud/mail/issues/6498

GretaD avatar Aug 01 '22 15:08 GretaD

All changed to the Material Design icon. While working on it, especially generating out the png versions, I was thinking which files of these are actually still necessary to manually create and which ones are generated by our theming. @juliushaertl do you know, and/or is this documented somewhere in the app dev docs?

jancborchardt avatar Aug 02 '22 14:08 jancborchardt

All changed to the Material Design icon. While working on it, especially generating out the png versions, I was thinking which files of these are actually still necessary to manually create and which ones are generated by our theming. @juliushaertl do you know, and/or is this documented somewhere in the app dev docs?

We still need them for cases where ImageMagick is not available or limited. E.g. it is quite common these days to have disable SVG reading by imagemagick in distributions by default, as this may bring additional risk with malicious files.

juliusknorr avatar Aug 02 '22 20:08 juliusknorr

Do we even use the icons changed with the latest commit https://github.com/nextcloud/mail/pull/6944/commits/505d682991a4ac55d15bc7750236a76b62a561b6? I think those are unused with your recent changes that dropped all custom icons.

ChristophWurst avatar Aug 09 '22 17:08 ChristophWurst

should all *.svg and *.png be commited / merged?

im not sure if i understand what refer with all, but in other apps we only do the svg, if the png is the same icon.

GretaD avatar Aug 12 '22 10:08 GretaD

@ChristophWurst no, they are not used anymore and can be removed. @GretaD you wanted to remove them right?

jancborchardt avatar Aug 17 '22 02:08 jancborchardt