mail icon indicating copy to clipboard operation
mail copied to clipboard

:framed_picture:

Open kesselb opened this issue 3 years ago • 1 comments

To do

  • [ ] Testing with Mailvelope
  • [ ] Convert base64 image to attachment
  • [ ] Evaluate isHtml flag for drafts when loading a message with a different format then account default (rich vs plain)
  • [ ] Set editor mode only for new messages

To discuss

  • Have account A (plain text) and account B (rich text). What should happen switching from rich text to plain text?

kesselb avatar Jul 26 '22 13:07 kesselb

oof

nice title though

miaulalala avatar Jul 26 '22 19:07 miaulalala

Nitpick: the image tool is very hidden Bildschirmfoto vom 2022-08-26 16-12-40

ChristophWurst avatar Aug 26 '22 14:08 ChristophWurst

  • [ ] BUG weird behavior with image in signature but plain editing as default
  1. Set the account to plain text emails
  2. Add an image to your signature
  3. Compose a message
  4. Switch to rich text

Expected: the image appears Actual: the image does not show

ChristophWurst avatar Aug 26 '22 14:08 ChristophWurst

:heavy_check_mark: Successfully tested embedding an image into a new HTML message :heavy_check_mark: Successfully tested embedding an image into my signature and sending an HTML message

ChristophWurst avatar Aug 26 '22 14:08 ChristophWurst

Have account A (plain text) and account B (rich text). What should happen switching from rich text to plain text?

We answered that, right? If there is content, the editing mode won't switch with the selection of another account. If the body is empty we switch modes according to account defaults.

ChristophWurst avatar Aug 26 '22 14:08 ChristophWurst

Add a warning for images > 128kb? (big base64 encoded images make the editor laggy and slow down sending)

Definitely. Does CKEditor have an option for this or allow us to hook into the selection?

ChristophWurst avatar Aug 26 '22 14:08 ChristophWurst

Adjusted the title so it can be found in the browser history

ChristophWurst avatar Aug 30 '22 11:08 ChristophWurst

Add a warning for images > 128kb? (big base64 encoded images make the editor laggy and slow down sending)

Let's do this as a follow-up so the basic image support can be part of this week's RC :+1:

ChristophWurst avatar Aug 30 '22 11:08 ChristophWurst

https://github.com/nextcloud/mail/pull/6935/commits/ca38fb75d175ec02ab7248bddedd792e368c830b add debounce for onInput event

Resolved via https://github.com/nextcloud/mail/pull/6935/commits/ea90bc1f4c668592e9d7d0ee1dfdf787077cd60b

kesselb avatar Sep 02 '22 13:09 kesselb