mail
mail copied to clipboard
nextcloud
change the composer modal size to large
Close https://github.com/nextcloud/mail/issues/6589
| Before | After |
|---|---|
 |
 |
Signed-off-by: szaimen [email protected]
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Fine by me! Then lets close this one and https://github.com/nextcloud/mail/issues/6589?
To also take into account @marcoambrosini’s issue report (Marco check my comment above on line length :) The default GMail composer size is the popover on the right, not the expanded one. Default one has 75 characters per line (upper limit), expanded has a super large 175 (not screenshotted, see issue https://github.com/nextcloud/mail/issues/6589 ).
We could think about introducing the ability to expand the composer, but that’s a separate issue. Default composer should stay within legible limits.
@jancborchardt keep in mind that our large modal size is not that large. If you look at the composer on a not zoomed in page you'll see it's really really tiny. Gmail's smaller composer is tiny too but they keep the rest of the page interactive while that's deployed, while we're blocking everything else.
To give a point of reference, a size large is the same as the app settings dialog. To me this would be pretty reasonable for Mail's composer. We could also bump the size of the text in the composer to 16 to make it more readable.
reference of a "large" modal window on a 16 inch screen with recommended scaling and no zoom in the web page
To give a point of reference, a size large is the same as the app settings dialog. To me this would be pretty reasonable for Mail's composer.
Personally I'm used to writing mails in full-page view such that fixing a window size seems undesirable to me. I'd like to have it at least adjustable by the user or even better provide the possibility to edit it on the right hand side (without pop-up) as it used to be the case (preferably the default behavior for this would be a setting somewhere).
I personally have to agree with Marco and Bibo-Joshi. The current modal window is super small. Can we keep the line lenght and increase font size while making the modal bigger, and possibly add an overlay? It feels fiddly.
Oh btw @jancborchardt I just noticed that the composer uses 13px as font size. Is there any reason for that? If we bump it to 15px and use the large modal size I think we'd have a reasonable line length.
Also agreed, if the composer was a popup composer on the right like in Gmail then it makes sense to keep it small, but seems to me that there is no use of keeping a modal-type focused composer which is so small. If you add attachments that's even lesser of the body text that's not visible. I think it's a good idea to increase the size, and possibly the font size as well :)
Oh btw @jancborchardt I just noticed that the composer uses 13px as font size. Is there any reason for that? If we bump it to 15px and use the large modal size I think we'd have a reasonable line length.
@marcoambrosini no, actually no specific reason for that except legacy I guess. @szaimen can you adjust that, then we see which modal size best fits our roughly ~75–80 characters with the new increased font size? :)