mail icon indicating copy to clipboard operation
mail copied to clipboard

Inconsistent background corner radius in left/middle rows

Open ChristophWurst opened this issue 2 years ago • 6 comments

Steps to reproduce

  1. Nothing specific to prepare but at least one account and some messages

Expected behavior

Consistent design

Actual behavior

Bildschirmfoto vom 2022-04-07 20-45-57 Bildschirmfoto vom 2022-04-07 20-46-09 Bildschirmfoto vom 2022-04-07 20-49-24 Bildschirmfoto vom 2022-04-07 20-49-17

Mail app version

1.x

Mailserver or service

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database

No response

Additional info

  • [ ] Requires https://github.com/nextcloud/nextcloud-vue/issues/2460 / https://github.com/nextcloud/nextcloud-vue/pull/2571
  • [ ] Requires https://github.com/nextcloud/nextcloud-vue/pull/2572

ChristophWurst avatar Apr 07 '22 18:04 ChristophWurst

@nimishavijay please give a feedback, which design should we use?

JuliaKirschenheuter avatar Apr 25 '22 08:04 JuliaKirschenheuter

Good point! We should change the component itself so that it is reflected across all apps :)

My suggestion:

  • border-radius: 6px for each item in the action menu
  • border-radius: 8px for the action menu itself
  • padding: 4px for the action menu

It would look like this image What do you think? cc @jancborchardt @marcoambrosini

nimishavijay avatar Apr 25 '22 10:04 nimishavijay

Yeeeeah that looks sick @nimishavijay! :)

Regarding the AppNavigation, there’s https://github.com/nextcloud/nextcloud-vue/issues/2460 which @quentinguidee / @marcoambrosini wanted to look at, so we should make sure it’s the same. :)

jancborchardt avatar Apr 25 '22 11:04 jancborchardt

This is too big of a change to be delivered with v1.12

ChristophWurst avatar Apr 29 '22 09:04 ChristophWurst

This seems to be fixed with the 2 Vue component pull requests, is it not?

jancborchardt avatar Jul 18 '22 11:07 jancborchardt

Yep this is fixed in master, needs release

marcoambrosini avatar Jul 18 '22 14:07 marcoambrosini

all background border corner radius are consistent everywhere in mail now

GretaD avatar Oct 17 '22 12:10 GretaD