mail icon indicating copy to clipboard operation
mail copied to clipboard

fix(ui): improve color contrast of tags

Open ChristophWurst opened this issue 1 month ago • 4 comments

Fixes https://github.com/nextcloud/mail/issues/5149

List Modal
Before Bildschirmfoto vom 2025-11-19 16-43-24 Bildschirmfoto vom 2025-11-19 16-43-38
Dark Bildschirmfoto vom 2025-11-19 16-40-12 Bildschirmfoto vom 2025-11-19 16-40-06
Bright Bildschirmfoto vom 2025-11-19 16-41-05 Bildschirmfoto vom 2025-11-19 16-41-28

ChristophWurst avatar Nov 19 '25 15:11 ChristophWurst

@nimishavijay could you please give early feedback? Is the approach acceptable design-wise?

ChristophWurst avatar Nov 19 '25 16:11 ChristophWurst

Nice improvements on the visual design aspects like rounding corners etc. I agree that the color contrast can be improved, but going with such bright colours seems like possibly a regression design-wise.

We could use very dark and very light versions of the tag color, similar to before, and additionally add a 1px border. Something like this: text colour: color-mix(in srgb, [tag color] 25%, var(--color-main-text) 100%) background: color-mix(in srgb, [tag color] 25%, var(--color-main-background) 100%) border: color-mix(in srgb, [tag color] 50%, var(--color-main-background) 100%)

since --main-text and --main-bg always have very high contrast, it should work. What do you think?

nimishavijay avatar Nov 20 '25 13:11 nimishavijay

The rounding is a side effect of deduplicating four copies of the more or less same code for tags 🌝

The tags will look like this with the suggested CSS:

Bildschirmfoto vom 2025-11-20 14-53-39

This works in terms of text readability but we'll lose most of the color

ChristophWurst avatar Nov 20 '25 13:11 ChristophWurst

You're right, but design wise this seems to be in the right direction (ref outlook as well) image

How about background: color-mix(in srgb, [tag color] 40%, var(--color-main-background) 100%) This should make it brighter in the background

nimishavijay avatar Dec 01 '25 12:12 nimishavijay