nextcloud
Replace tune icon with filter icon
Fixes: #9942
Check commit.
I don't have a test environment. Test from reviewers need.
The icon component is not registered on the Vue component
@ChristophWurst this is new for me ; how to do that ? Can you help me ?
Delete https://github.com/nextcloud/mail/blob/295a1dcf4c98da0ca46a03847c5bb9a320295f03/src/components/SearchMessages.vue#L299 and replace Tune with FilterIcon at https://github.com/nextcloud/mail/blob/295a1dcf4c98da0ca46a03847c5bb9a320295f03/src/components/SearchMessages.vue#L321
Delete
https://github.com/nextcloud/mail/blob/295a1dcf4c98da0ca46a03847c5bb9a320295f03/src/components/SearchMessages.vue#L299 and replace Tune with FilterIcon at
https://github.com/nextcloud/mail/blob/295a1dcf4c98da0ca46a03847c5bb9a320295f03/src/components/SearchMessages.vue#L321
@ChristophWurst OK
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the blocklist.)
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Jerome-Herbinet as per my comment before, the icon probably needs to be "FilterVariant".
It should not look like this funnel icon, but rather like this list filter icon.
OK @jancborchardt ; to make finding icons easier, can you tell me how (and/ore where) you easily browse your entire Nextcloud icon collection to select the right one (AFAIK I can't open files viewed as an image...).
@Jerome-Herbinet as far as I know, that is https://pictogrammers.com/library/mdi/ – but a frontender would have to help here.
What was force pushed? The icon is still to be replaced, right?
Yes, forget it, I still have to make discussed changes.