ldap_write_support icon indicating copy to clipboard operation
ldap_write_support copied to clipboard

Do not rely on exop_passwd

Open susnux opened this issue 1 year ago • 9 comments

  • Fixes #128

Instead of relying on exop_passwd for password changing, check rootDSE for support and fallback to mod_replace otherwise. This should fix AD support.

susnux avatar Oct 17 '22 08:10 susnux

AD really does not support password EXOP?

come-nc avatar Oct 17 '22 10:10 come-nc

How about adding a dropdown setting for the password handling:

  • Default
    • Same as current handling with fallback to userPassword
  • Hash
    • Manually hash the password using ssha
  • Unicode
    • Required for AD without heuristics, setting password to unicodePwd and convert it to UTF16

susnux avatar Oct 17 '22 10:10 susnux

I am a bit uneasy having a fallback from passwd exop to modify on failure. If passwd exop is advertised as supported by rootDSE upon default config it should try the exop and error out on failure.

come-nc avatar Oct 17 '22 11:10 come-nc

@come-nc

I am a bit uneasy having a fallback from passwd exop to modify on failure. If passwd exop is advertised as supported by rootDSE upon default config it should try the exop and error out on failure.

I agree! Now if rootDSE advertises the password exop, an error will be thrown if it does not succeed. But if password exop is not supported the password is set by using the userPassword or (if configured) unicodePwd for AD support.

susnux avatar Oct 19 '22 15:10 susnux

@come-nc @blizzz I rebased this, is there anything I can help with to get this merged?

(Drone is failing because of https://github.com/nextcloud/ldap_write_support/pull/579 )

susnux avatar May 20 '23 12:05 susnux

@come-nc fixed your comments

susnux avatar May 22 '23 14:05 susnux

Any idea when this PR will make it's way through? Debating on handling via a custom branch or not.

Fmstrat avatar May 30 '23 15:05 Fmstrat

CI is failing

blizzz avatar Sep 22 '23 12:09 blizzz

@blizzz

CI is failing

I was able to finally solve this (was a typo :sweat_smile: )

susnux avatar Apr 29 '24 23:04 susnux