Revamp Settings Section: Complete Migration to Swift & SwiftUI - Code in Nextcloud / iOS -

[marinofaggiana]

https://github.com/nextcloud/ios/pull/2826

• Some improvement of code and normalized the GUI

[marinofaggiana]

@adityagi02 , @mpivchev continue here the revamp settings.

• @adityagi02 : please look & fix the NCAutoUploadFileNamesView.swift
• @adityagi02 : DefaultViewModifier.swift never called (?)

[adityagi02]

@adityagi02 , @mpivchev continue here the revamp settings.

• @adityagi02 : please look & fix the NCAutoUploadFileNamesView.swift
• @adityagi02 : DefaultViewModifier.swift never called (?)

Yeah, sure. Will work on the review points.

[marinofaggiana]

@adityagi02 now the passcode is fixed.

about the @State private var, for example showAcknowledgements = false, it wouldn't be enough in the Button(action: { set showAcknowledgements.toggle() without pass $showAcknowledgements to view ?

passcode view:

Button(action: {
                    showPasscode.toggle()
                }, label: {
                    HStack {
                        Image(systemName: model.isLockActive ? "lock" : "lock.open")
                            .resizable()
                            .scaledToFit()
                            .font(Font.system(.body).weight(.light))
                            .foregroundColor(Color(NCBrandColor.shared.iconImageColor))
                            .frame(width: 20, height: 20)
                        Text(model.isLockActive ? NSLocalizedString("_lock_active_", comment: "") : NSLocalizedString("_lock_not_active_", comment: ""))
                    }
                    .font(.system(size: 16))
                })
                .tint(Color(NCBrandColor.shared.textColor))
                .sheet(isPresented: $showPasscode) {
                    PasscodeView(isLockActive: $model.isLockActive)
                }

[adityagi02]

@adityagi02 now the passcode is fixed.

about the @State private var, for example showAcknowledgements = false, it wouldn't be enough in the Button(action: { set showAcknowledgements.toggle() without pass $showAcknowledgements to view ?

passcode view:

Button(action: {
                    showPasscode.toggle()
                }, label: {
                    HStack {
                        Image(systemName: model.isLockActive ? "lock" : "lock.open")
                            .resizable()
                            .scaledToFit()
                            .font(Font.system(.body).weight(.light))
                            .foregroundColor(Color(NCBrandColor.shared.iconImageColor))
                            .frame(width: 20, height: 20)
                        Text(model.isLockActive ? NSLocalizedString("_lock_active_", comment: "") : NSLocalizedString("_lock_not_active_", comment: ""))
                    }
                    .font(.system(size: 16))
                })
                .tint(Color(NCBrandColor.shared.textColor))
                .sheet(isPresented: $showPasscode) {
                    PasscodeView(isLockActive: $model.isLockActive)
                }

okay, can we have a quick call regarding this? @marinofaggiana