helm icon indicating copy to clipboard operation
helm copied to clipboard

chore: upgrade postgresql to 17.2 (chart 16.3.1)

Open GreyXor opened this issue 1 year ago • 14 comments

Description of the change

Update postgresql to 17.0 (chart version is 16.0) close #641

Benefits

GreyXor avatar Oct 03 '24 09:10 GreyXor

Thanks, the version number of the Chart needs to be bumped as well. @jessebot @wrenix does this justify bumping the major version or would the minor version be enough?

provokateurin avatar Oct 03 '24 10:10 provokateurin

Thanks, the version number of the Chart needs to be bumped as well. @jessebot @wrenix does this justify bumping the major version or would the minor version be enough?

Thanks, I'll update it when we know which version we need here :+1:

GreyXor avatar Oct 03 '24 12:10 GreyXor

I have to take a look in the bitmani chart (if it make some migrates). If not, i will bump a major version (like the bitmani chart too) and write a Changelog / Migration step.

PS: Private i wrote my own postgresql chart and use there the pgautoupgrade as init container (with PGAUTO_ONESHOT=yes) ...

wrenix avatar Oct 06 '24 12:10 wrenix

PS: Current PostgreSQL is not supported by Nextcloud (a Warnung appears): nextcloud/server#48495

wrenix avatar Oct 10 '24 17:10 wrenix

So better not merge it yet until any Nextcloud version officially supports it. It might just be alright, but better safe than sorry.

provokateurin avatar Oct 10 '24 20:10 provokateurin

Hoi! Yes, it should be a major update to the chart, as otherwise, it will attempt to upgrade a major version of the database if a user is using the bundled postgresql with this chart. I actually didn't know postgresql was supported by nextcloud at all :O Agree, if it is supported we should wait on this merge.

jessebot avatar Oct 20 '24 11:10 jessebot

Nextcloud now officially support postgresql 17: https://github.com/nextcloud/server/pull/49240 @provokateurin @wrenix Thanks 👋

GreyXor avatar Nov 13 '24 11:11 GreyXor

That will only be in Nextcloud 31, so still not ready.

provokateurin avatar Nov 13 '24 12:11 provokateurin

That will only be in Nextcloud 31, so still not ready.

In the meantime, waiting for 31. Does this PR seem ready to be merged? Or are there things to add/modify?

GreyXor avatar Nov 13 '24 12:11 GreyXor

nice do You like to make it merge ready? Maybe https://github.com/nextcloud/server/commit/dea6bd73620b2a033f59b506b1c5f1466d37dd54 would be in v30.0.3 ;)

Like to sign-of your commits (DCO check)

wrenix avatar Nov 15 '24 16:11 wrenix

would be in v30.0.3

No it won't, it is not on the stable30 branch which means it will be only in Nextcloud 31.

provokateurin avatar Nov 15 '24 17:11 provokateurin

Can we please keep it as a draft until we have Nextcloud 31 support in the chart?

provokateurin avatar Nov 19 '24 09:11 provokateurin

hi @provokateurin @wrenix
can I have a review ? nextcloud 31 will be soon be pushed to docker hub and then this helm can be updated to V7 Thanks

GreyXor avatar Feb 25 '25 08:02 GreyXor

Has somebody test a automatical migration? Maybe like:

postgresql:
  primary:
    initContainers:
      - name: upgrade
        image: "pgautoupgrade/pgautoupgrade:17-alpine"
        env:
          - name: "PGAUTO_ONESHOT"
            value: "yes"
        volumeMounts:
          - mountPath: "/bitnami/postgresql"
            name: "data"

wrenix avatar Mar 06 '25 16:03 wrenix

Has somebody test a automatical migration? Maybe like:

I tried it with authentik since that chart also had the same version upgrade and i upgraded that today it worked like this, ig you would need to add credentials for nextcloud as well


      primary:
        initContainers:
          - name: pgautoupgrade
            image: "pgautoupgrade/pgautoupgrade:17-alpine"
            env:
              - name: "PGAUTO_ONESHOT"
                value: "yes"
              - name: "PGDATA"
                value: "/bitnami/postgresql/data"
              - name: "POSTGRES_PASSWORD"
                valueFrom:
                  secretKeyRef:
                    name: "authentik-postgres-credentials"
                    key: "password"
            securityContext:
              runAsUser: 0
            volumeMounts:
              - mountPath: "/bitnami/postgresql"
                name: "data"

ojsef39 avatar Jun 19 '25 20:06 ojsef39