nextcloud
feat(nextcloud): add support of imaginary an externalPreviewProvider
Description of the change
Benefits
- faster image rendering for preview
- nextcloud container is not killed (e.g. OOM) if big and much preview images are generated
Possible drawbacks
Works for me
Checklist
- [x] I have read the CONTRIBUTING.md doc.
- [x] DCO has been signed off on the commit.
- [x] Chart version bumped in
Chart.yamlaccording to semver. - [x] (optional) Parameters are documented in the README.md
Sorry, I don't have the time for that atm. I hope I can do it at some point, but only at the beginning of next month the earliest.
oh this is neat! May I ask what the difference between this and the preview generator app are? (I'm not against it btw, just want to learn more) I will review this more thoroughly as soon as I have a moment 🙏
Thank you for working on this :rocket:
Just wanted to point out that, with Nextcloud 30, the OC\Preview\Imaginary provider no longer generates PDF previews. It may be worth considering adding the new ImaginaryPDF provider to the Imaginary notes in the README.md file.
See https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_30.html#previews-for-pdf-files-with-imaginary
Thanks again, looking forward to using it to speed up my (terribly slow) Nextcloud media previewing :heart:
rebased on main and add docu in e393d908f51d040ae6040d32136a3f530614caa3 like @SIMULATAN suggested
rebased - Does i interprate you @jessebot last comment correct, that i could merge it?
It would be nice to add a test that generating the preview works (similar to how we test S3 in the job).
Yes, it would be nice - i do not know when a preview generation is triggered (i believe in viewing)
You can request a preview via https://github.com/nextcloud/server/blob/b5ac989ecd4e6f380af4699cb8c0aae872284459/core/openapi.json#L8178
I found the bug, in the container (why setup of test does not run) ....
So here are the test online.