helm icon indicating copy to clipboard operation
helm copied to clipboard

Add missing S3 parameters

Open jessebot opened this issue 1 year ago • 3 comments

Description of the change

This adds the remaining variables that are due to eventually be added in the upstream https://github.com/nextcloud/docker/pull/2271. All of these parameters are documented here.

Benefits

Now users will be able to set every single documented Nextcloud S3 parameter, even if it's not yet supported in the docker image upstream.

Possible drawbacks

Some of these env vars are not yet merged in the docker container repo, which may cause some confusion, but shouldn't make a difference overall.

Applicable issues

  • fixes #612

Additional information

Checklist

jessebot avatar Jul 29 '24 09:07 jessebot

oops, forgot to update the README. Let me do that 🤦 Edit: done.

jessebot avatar Jul 29 '24 09:07 jessebot

Taking a look at why the test failed now 🤔 (edit: was a typo, is now fixed)

jessebot avatar Jul 29 '24 10:07 jessebot

As I said in https://github.com/nextcloud/helm/pull/613#issuecomment-2255422641 I feel it is better to let upstream confirm the changes since they know best how to do this stuff. You already mentioned the config files being out of sync can cause confusion and I'd like to avoid that.

provokateurin avatar Jul 29 '24 10:07 provokateurin