helm icon indicating copy to clipboard operation
helm copied to clipboard

Feature: Separate value for NEXTCLOUD_TRUSTED_DOMAINS

Open Nils98Ar opened this issue 1 year ago • 1 comments

Description of the change

Introduce separate value e.g. nextcloud.trustedDomains that fills NEXTCLOUD_TRUSTED_DOMAINS environment variable if set. Otherwise use nextcloud.host as default.

Benefits

It would be possible to use alias domains for the instance.

Possible drawbacks

I don't know any.

Nils98Ar avatar Aug 08 '23 15:08 Nils98Ar

I think this has been mentioned before, but I think it's a good idea regardless. I want to work on this, but realistically probably won't get to it for another few weeks to a month or so. If you or anyone else would like to submit a PR for this, I'd be happy to help review it, if no other collaborators can at the time :)

Some things to consider for a PR: Make sure to update:

  • README.md configurations markdown table in the charts/nextcloud directory
  • values.yaml with your new parameter
  • any affected templates such as deployment.yaml or _helpers.tpl
  • the version in Chart.yaml

jessebot avatar Aug 20 '23 07:08 jessebot