health icon indicating copy to clipboard operation
health copied to clipboard

No duration is shown in the sleeping graph

Open Sputnikchen opened this issue 2 years ago • 1 comments

1.) No duration is shown in the sleeping graph. Only quality and wakeups grafik 2.) Quality chart should be inverted. 'Very low' should be '0' and 'very good' should be '4'.

Sputnikchen avatar May 23 '22 06:05 Sputnikchen

Hi, regarding your point number 1, it looks like you can hover over a period of sleep (light-purple color box), and the mouse tooltip will tell you the duration in hours. sleep-duration As for point 2 I agree! Would it just be as simple as flipping the quality id values around in src/modules/sleep/SleepTable.vue? I would imagine if these values are just used for rendering the graph it would be okay to make this change, but if they're used to store the sleep data then it could break things if you don't go back and correct all the stored data too. If it is just used to render the graph and if it's really this simple, I will submit a PR and just flip like so:

{ id: 0, label: t('health', 'Perfect', {}) }    -->   { id: 4, label: t('health', 'Perfect', {}) }
{ id: 1, label: t('health', 'Fine', {}) }       -->   { id: 3, label: t('health', 'Fine', {}) }
{ id: 2, label: t('health', 'Okay', {}) }       -->   { id: 2, label: t('health', 'Okay', {}) }
{ id: 3, label: t('health', 'Low', {}) }        -->   { id: 1, label: t('health', 'Low', {}) }
{ id: 4, label: t('health', 'Very low', {}) }   -->   { id: 0, label: t('health', 'Very low', {}) }

Just hoping someone can confirm this is okay before I submit it.

BraidenPsiuk avatar Oct 18 '23 05:10 BraidenPsiuk