Add 'direct' GET param to invite email 'view share' link

[julien-nc]

If user_saml or user_oidc are configured to automatically redirect the login page to an IdP, guests can't authenticate when clicking the link included in the share/invite email.

Adding the direct=1 GET param to the /f/FILE_ID link works because the GET param is preserved when being redirected to the login page.

Should this be optional? I think it's fine to always have it since we know we want a direct login for guests. Wdyt?

[nickvergessen]

@blizzz i only know the direct from saml, any chance this conflicts/creates an issue?

[blizzz]

@blizzz i only know the direct from saml, any chance this conflicts/creates an issue?

No, this should be all fine.

[julien-nc]

@blizzz Thanks

Static analysis failure is due to a new method recently added in lib/private/Files/Storage/Wrapper/Wrapper.php https://github.com/nextcloud/server/blame/master/lib/private/Files/Storage/Wrapper/Wrapper.php#L678-L680

[solracsf]

All green now 🟢