nextcloud
Calculate the available width for the breadcrumb based on shown buttons
From @oparoz on October 18, 2015 14:27
The app is currently using the worst case scenario, the one where all buttons are shown, which means that there will be a large gap on public galleries per example if the only button shown is the switch to Files button.
The plan is to add 50px per button at view init time.
In more details
We define Gallery.buttonsWidth at 350 pixels. that's the worst case scenario.
When the view is resized, we do this:
Gallery.view.breadcrumb.setMaxWidth($(window).width() - Gallery.buttonsWidth);
The 350 pixels area may not necessarily be filled with buttons, leaving some empty space.
Plan
- [ ] List all buttons which can be shown on the controls bar
- [ ] List the minimum number of buttons which can be show on the interface
- [ ] Define the number of pixels a button takes
- [ ] Write a function which updates Gallery.buttonsWidth based on the number of buttons currently shown
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Copied from original issue: owncloud/gallery#443
From @imjalpreet on March 8, 2016 12:50
@oparoz I want to fix this issue. Can you please tell a little more about what needs to be done in this? Secondly, can you also assign me some more tasks, so that I can get used to the code? Thanks!
I've updated the OP with more details. That gives you a bit of investigating work to do to familiarise yourself with the GUI components.
Regarding tasks, do you want to stay with Javascript or do you want to start working on some PHP jobs? In general, any task with a label "Coder wanted" can be picked and I can clarify some of them or tell you if it's not the right time to look at it, etc.
From @imjalpreet on March 8, 2016 16:49
@oparoz I will have a look at the updated description. Secondly, I am fine with both PHP and JS Jobs. Can you suggest me some jobs that can be looked at now? Thanks!
Here is a selection: #4 https://github.com/owncloud/gallery/issues/193#issuecomment-133676344 #213 #565 There is also a PR which could be finished, but you'll have to ask the person currently assigned: https://github.com/owncloud/gallery/pull/512
If none of them float your boat, let me know and I'll try to find bigger tasks.
From @imjalpreet on March 8, 2016 20:23
@oparoz Cool! I will have a look at all of them along with this one and get back to you. :+1:
OK and remember to sign the contributor agreement if you intend on delivering larger PRs. That way you can also manage labels and assign yourself to tasks.
From @imjalpreet on March 8, 2016 20:28
@oparoz Yeah Sure. Where can I find the contributor agreement?
From @imjalpreet on March 10, 2016 14:44
@oparoz I am having a look at those basic app ideas that you have added. I will start developing one of those to have grip on the AppFramework. Thanks!
From @imjalpreet on March 10, 2016 14:47
@oparoz Secondly, Where can I communicate with you regarding GSoC projects? Is IRC fine?
I'm rarely on IRC, unless I'm working on something as it's too distracting and unreliable. Emails works best, unless code needs to be discussed live, in which case we can meet on IRC.