forms icon indicating copy to clipboard operation
forms copied to clipboard

feat: add form locking mechanism and share `edit` permission

Open Chartman123 opened this issue 8 months ago • 3 comments

  • [x] lock form in backend
  • [x] add lockedBy and lockedUntil to getForm and getForms
  • [x] adjust documentation to reflect changes in form data structure and API behavior.
  • [x] allow adding edit permission to shares in frontend (backend already handles it correctly)
  • [x] respect locked form state in frontend
  • [x] allow form owner to lock form completely
  • [x] allow form owner to remove a lock
  • [ ] add/adjust tests

What should someone with edit permissions be able to do?

  • [x] only the form owner can transfer ownership
  • [x] only the form owner can lock a form completely/remove an existing lock
  • [ ] edit form:
    • [x] title
    • [x] description
    • [x] submissionMessage
    • [x] expiration
    • [x] show expiration
    • [x] state closed
    • [ ] state archived
    • [x] anonymous answers
    • [x] submit once/multiple
    • [x] allow edit submissions
    • [x] edit access (permitAllUsers, showToAllUsers)
    • [x] link/unlink files
  • [ ] delete form
  • [x] add/edit/delete questions
  • [x] add/edit/delete options
  • [ ] add/edit/delete shares

Chartman123 avatar May 11 '25 22:05 Chartman123

#936

hamza221 avatar May 12 '25 09:05 hamza221

Codecov Report

:x: Patch coverage is 31.16279% with 148 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.12%. Comparing base (3adb419) to head (aa8eca7). :warning: Report is 95 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2737      +/-   ##
============================================
- Coverage     45.48%   44.12%   -1.37%     
- Complexity      987     1022      +35     
============================================
  Files            79       80       +1     
  Lines          3586     3683      +97     
============================================
- Hits           1631     1625       -6     
- Misses         1955     2058     +103     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 14 '25 23:05 codecov[bot]

@susnux @hamza221 should be ready for a first review :)

Chartman123 avatar May 16 '25 23:05 Chartman123