flow_notifications icon indicating copy to clipboard operation
flow_notifications copied to clipboard

Notifications don't trigger for actions initiated by yourself

Open theCalcaholic opened this issue 4 years ago • 8 comments

I have set up a simple test case:

image

The NC Talk flow is just there to verify that I didn't misconfigure the conditions. When I edit/rename a file called test.md to test1.md (or vice versa), I get a message in Talk but no notification.

NC version: 20.0.4 Flow Notifications version: 1.0.3

theCalcaholic avatar Feb 10 '21 01:02 theCalcaholic

Can confirm with: NC version: 20.0.5 Flow Notifications version: 1.0.3

MarVinSto avatar Feb 10 '21 09:02 MarVinSto

Can confirm with: NC version: 20.0.8 Flow Notifications version: 1.0.3

snarchio avatar Feb 26 '21 09:02 snarchio

Cannot confirm on 20.0.8 / 1.0.3.

Please note that the notification is not triggered, when you do the action yourself.

blizzz avatar Feb 26 '21 09:02 blizzz

Cannot confirm on 20.0.8 / 1.0.3.

Please note that the notification is not triggered, when you do the action yourself.

Sorry, my mistake in testing after the update

snarchio avatar Feb 26 '21 11:02 snarchio

@blizzz Oh, so this is intended behavior? IMO, this could be configurable. I don't always access files manually, but also in various automated tasks via scripts, which might be a use case for this flow.

Anyways, I'll test the app with another user and report back in a minute.

theCalcaholic avatar Mar 01 '21 16:03 theCalcaholic

@blizzz Oh, so this is intended behavior? IMO, this could be configurable. I don't always access files manually, but also in various automated tasks via scripts, which might be a use case for this flow.

Anyways, I'll test the app with another user and report back in a minute.

Yes, it is intended and also worked like this. Does not mean it has to be like this forever (but then opt-in).

blizzz avatar Mar 01 '21 18:03 blizzz

Cannot confirm on 20.0.8 / 1.0.3.

Please note that the notification is not triggered, when you do the action yourself.

Sorry, this was my fault! Is it possible that notifications are also not created if the files are in group folders? If yes: Is there a workaround to make that happen?

MarVinSto avatar Apr 28 '21 07:04 MarVinSto

Is it possible that notifications are also not created if the files are in group folders?

This should not be the case. There is no introspection into files. The check for ownership as pointed out above is the only one we do in this app.

blizzz avatar Oct 22 '21 19:10 blizzz