files_texteditor icon indicating copy to clipboard operation
files_texteditor copied to clipboard

Please add compatibility for NC28

Open snagglewest opened this issue 1 year ago • 23 comments

Please add compatibility for NC28

snagglewest avatar Jan 10 '24 13:01 snagglewest

I have just come to NextCloud in v28. I cannot understand why they insist on treating all text as Markdown and force a WYSIWYG editor. I want to edit my Markdown as plain text, please!

SteveDinn avatar Feb 16 '24 16:02 SteveDinn

Nothing but bot stuff for the last 7 months... Is this project dead ?

red3333 avatar Feb 20 '24 08:02 red3333

I miss this app to update to v28 :-(

Polve avatar Mar 12 '24 15:03 Polve

I re-enabled the app on NC28 and it seems to be working fine for me. No log errors and it edits the files as before. Will monitor it for problems but seems like there may not be breaking changes in NC28 and the app just needs updated to flag it as compatible.

inguy24 avatar Mar 28 '24 19:03 inguy24

Thank you for the update @inguy24 !

So are you saying tha it still appears in the menu and can it coexist with the official Text app?

elpraga avatar Mar 28 '24 20:03 elpraga

I am not sure what the official text app is, but yes, the app seems to function normally and is in the menu. Again, it is functioning for me with my configuration and will continue to monitor for issues. I can not guarantee it will work for everyone.

I would experiment with enabling it in a test environment or, if no test environment, on a production server during a time that you can afford to have your system offline if things don't go well. Be familiar with the occ commands to disable the app if need be.

⁣Get BlueMail for Android ​

On Mar 28, 2024, 1:52 PM, at 1:52 PM, elpraga @.***> wrote:

Thank you for the update @inguy24 !

So are you saying tha it still appears in the menu and can it coexist with the official Text app?

-- Reply to this email directly or view it on GitHub: https://github.com/nextcloud/files_texteditor/issues/816#issuecomment-2026093902 You are receiving this because you were mentioned.

Message ID: @.***>

inguy24 avatar Mar 28 '24 22:03 inguy24

So I re-tested with the latest Nextcloud 28.0.4:

  1. I disabled the (official) "Text" app and "Plain text editor" app
  2. I tried to open a .txt file (click on it), logically, as no text app is enabled on Nextcloud, the file is downloaded instead of opened.
  3. I enabled "Plain text editor", then opened a .txt file, still downloaded
  4. I enabled (official) "Text" app, then opened a .txt file, it gets opened for editing (in "Text" app, which I like less...)

I have the feeling that the "Plain text editor" app does no get registered as a text editor app in Nextcloud 28.

red3333 avatar Mar 29 '24 09:03 red3333

That behavior would be quite desirable as long as the option to open with plain text editor remains accessible through the menu (hence the question on my previous post)

Those who only want to use the Plain Text editor app can uninstall the Text app.

Those who do not want to use the Plan Text app do not install it at all

And those (like me) who would use the Text app for most files, but do need the ability to edit some text files directly can do so using the menu and choosing the Plain Text app.

On Fri, 29 Mar 2024, 10:12 red3333, @.***> wrote:

So I re-tested with the latest Nextcloud 28.0.4:

  1. I disabled the (official) "Text" app and "Plain text editor" app
  2. I tried to open a .txt file (click on it), logically, as no text app is enabled on Nextcloud, the file is downloaded instead of opened.
  3. I enabled "Plain text editor", then opened a .txt file, still downloaded
  4. I enabled (official) "Text" app, then opened a .txt file, it gets opened for editing (in "Text" app, which I like less...)

I have the feeling that the "Plain text editor" app does no get registered as a text editor app in Nextcloud 28.

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/files_texteditor/issues/816#issuecomment-2026921702, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJMWKV2BMNHS5ABZFTBX3LY2UO5HAVCNFSM6AAAAABBU2UVQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWHEZDCNZQGI . You are receiving this because you commented.Message ID: @.***>

elpraga avatar Mar 29 '24 09:03 elpraga

Ahh, sorry, it's morning here, and my eyes haven't opened properly yet...

I missed the "still downloaded" part.

Could you please check if files can be edited using the Plain Text editor thorough the menu?

elpraga avatar Mar 29 '24 09:03 elpraga

So I re-tested with the latest Nextcloud 28.0.4:

1. I disabled the (official) "Text" app and "Plain text editor" app

2. I tried to open a .txt file (click on it), logically, as no text app is enabled on Nextcloud, the file is downloaded instead of opened.

3. I enabled "Plain text editor", then opened a .txt file, still downloaded

4. I enabled (official) "Text" app, then opened a .txt file, it gets opened for editing (in "Text" app, which I like less...)

I have the feeling that the "Plain text editor" app does no get registered as a text editor app in Nextcloud 28.

Going back to step 3., there is no option in the menu for editing the file (while in step 4. the option is present and opens with (official) "Text" app)

red3333 avatar Mar 29 '24 09:03 red3333

I also tried to just "force enable" it, and there's no text editing menu entry for me in NC 28 either, unfortunately. :-(

gohrner avatar Mar 29 '24 21:03 gohrner

With the significant changes to the files app in 28 the way this app hooks into the files ui needs to be reworked.

Ideally this would be done as a viewer plugin. I've started a basic POC but probably don't have the time to finish it: https://github.com/nextcloud/files_texteditor/pull/860

icewind1991 avatar Apr 11 '24 15:04 icewind1991

Please add compatibility for NC28

haohetao avatar Apr 19 '24 02:04 haohetao

Hi @icewind1991

I've started a basic POC but probably don't have the time to finish it

How concrete is this splendid idea in the meantime? Can we hope for a replacement solution for the plain text editor or is that still up in the air?

ernolf

ernolf avatar May 21 '24 11:05 ernolf

Please add compatibility for NC28.

workingmachine avatar May 23 '24 16:05 workingmachine

By this point, it might be better to add support for NC29.

daffydock avatar May 24 '24 18:05 daffydock

I'm looking forward to this fix so that files_markdown will work again soon.

ahaubold avatar Jun 21 '24 18:06 ahaubold

By this point, it might be better to add support for NC29.

Would that also add support for NC28 at the same time?

jahway603 avatar Jun 27 '24 17:06 jahway603

I have just come to NextCloud in v28. I cannot understand why they insist on treating all text as Markdown and force a WYSIWYG editor. I want to edit my Markdown as plain text, please!

Sorry if this is off topic here with respect to NC28 compatibility. But you can switch to plain text editing for markdown with a app config setting:

 occ config:app:set text rich_editing_enabled --value="0" 

max-nextcloud avatar Jul 10 '24 15:07 max-nextcloud

I have just come to NextCloud in v28. I cannot understand why they insist on treating all text as Markdown and force a WYSIWYG editor. I want to edit my Markdown as plain text, please!

Sorry if this is off topic here with respect to NC28 compatibility. But you can switch to plain text editing for markdown with a app config setting:

 occ config:app:set text rich_editing_enabled --value="0" 

Indeed, a bit off topic, true, but still very relevant and useful. Thank you @max-nextcloud for sharing. For the time being, applying this change brings me back to where I want to be until an update comes. Plus, it makes the Text app run a bit faster, so if it can work, even as a stopgap for others, then I recommend to give it a go.
Cheers.

daffydock avatar Jul 10 '24 19:07 daffydock

IMHO, the best implementation of a markdown editor is in the Notes app. It allows you to switch back and forth between editing (markdown, but a kind of WYSIWIG markdown) and viewing, where it shows everything without the markdown symbols.

The editor in the default text editor is the worst out of all of them. I often find it very hard to get it to do what I want. Setting that rich_editing_enabled config option to 0 doesn't allow you to see the markdown in "viewing" mode at all anymore.

SteveDinn avatar Jul 17 '24 17:07 SteveDinn