files_rightclick icon indicating copy to clipboard operation
files_rightclick copied to clipboard

No translation - Share ...

Open Valdnet opened this issue 5 years ago • 3 comments

There is no translation for:

  • Share file
  • Share folder

for deleted files (trash).

obraz

It's the code line: https://github.com/nextcloud/files_rightclick/blob/48436318524a754b61273b8648cab34b4ca4d812/js/files.js#L85

There is a translation into Transifex for the Polish language. In my opinion, this option should be available in the "All files" menu, not in "Deleted files".

App: Nextcloud 17.0.2 Right click 0.15.1

Valdnet avatar Jan 16 '20 14:01 Valdnet

@NastuzziSamy, @rullzer, @nickvergessen In the "files_rightclick" module, the following errors occur in addition to the one indicated above:

  1. In "Files", after selecting the file and clicking the right mouse button on the menu should not find the option "Delete permanently" and after clicking on this option nothing happens. This function is superfluous, because it should only be in "Trash".

obraz

  1. In "Trash" after selecting the file and right-clicking on the menu, the option "Trash" should not appear. And again, as in the previous case, nothing happens after clicking.

obraz

In both cases, the items listed are superfluous.

Nextcloud 18.0.3 and 19.0.0 beta2 Right click 0.16.0

Valdnet avatar Apr 12 '20 11:04 Valdnet

Yeah, the app should not recreate the actions from the ... menu but inherit them from there instead.

nickvergessen avatar Apr 12 '20 12:04 nickvergessen

One of the errors still exists in NC 22.0.0:

obraz

Steps:

  1. Delete file.
  2. Select "Deleted files" from the menu.
  3. Right click on the deleted file.

App: Nextcloud 22.0.0 Right click 1.1.0

Valdnet avatar Jul 13 '21 13:07 Valdnet