Allow slideshow with PDFs

[skjnldsv]

Fix #444

[szaimen]

Hm.. I am not sure about this as it will now overlay important controls:

Desktop	Mobile

[skjnldsv]

blocking. See my comment above

Hum, no idea how to solve that. Jan approved adding the slideshow

[szaimen]

Hum, no idea how to solve that. Jan approved adding the slideshow

yeah, but he was probably not aware about the conflict with these buttons...

[skjnldsv]

@jancborchardt @nimishavijay what do you reckon ? :)

[artonge]

Nice catch @szaimen, I would put the navigation behind the menu. I just checked and that's what the Gnome image viewer is doing:

Closed	Open

[nimishavijay]

Suggestion by @artonge sounds good to me 🚀

[szaimen]

Nice catch @szaimen, I would put the navigation behind the menu. I just checked and that's what the Gnome image viewer is doing:

the only problem that I see with that is that the pdfviewer is loaded in an iframe and I am not sure if it is possible to inject the overlay buttons into the iframe...

cc @skjnldsv

[skjnldsv]

the only problem that I see with that is that the pdfviewer is loaded in an iframe and I am not sure if it is possible to inject the overlay buttons into the iframe...

Nope, indeed. We'd have to think differently :( Maybe reduce the arrow's height and hide them when the menu is opened :thinking:

[szaimen]

hide them when the menu is opened 🤔

this sounds good to me 👍

[gpz1100]

How about just lowering those bottoms, and/or implementing left/right keys on devices with keyboards? There's already a handler for the escape key, why not monitor for L/R too?

Actually, for esc, one needs to click on the top bar (where the X is ) first before escape works.

[gpz1100]

Has some form of this enhancement made it into the 25.xx beta? I installed 25.0.0 RC1 into a vm but don't see any change in pdf navigation. Thank you

[skjnldsv]

@gpz1100 no, this is not merged, see assigned 26 milestone

[Io-Qo]

I think this is a very important feature and should be added soon as navigating through files should be easy within Nextcloud. I reckon the navigation should be added to the sidebar rather than through the slideshow feature, as it would circumvent all problems pointed out by @szaimen and would be an universal approach to all files, not just PDFs etc. Navigation buttons (previous/next file) in the sidebar would make more sense to me.

[gpz1100]

I'm confused, is this feature currently offered or will be offered or is being discarded entirely?

[skjnldsv]

@gpz1100 Unfortunately seems the requests for this are quite low, if anyone wants to take over, feel free :+1: