files_lock icon indicating copy to clipboard operation
files_lock copied to clipboard

Admin needs to unlock files

Open tobiasKaminsky opened this issue 3 years ago • 7 comments

  • admin should see a list of currently locked files
  • admin can unlock them
  • for privacy reasons only fileId should be shown --> this can "easily" found by user via looking at "internal share" link

tobiasKaminsky avatar Jan 25 '22 06:01 tobiasKaminsky

UI wise a list of file ids is not very nice, so I would say we just have an input for the file id, if showing paths is not feasible for privacy reasons.

This is currently already possible through occ:

occ files:lock -u 123 admin

juliusknorr avatar Mar 10 '22 19:03 juliusknorr

I am fine with this, as this should not often needed. cc @AndyScherzinger @jancborchardt

tobiasKaminsky avatar Mar 11 '22 07:03 tobiasKaminsky

UX question, so I am very interested in @jancborchardt's view on this.

AndyScherzinger avatar Mar 11 '22 11:03 AndyScherzinger

Some additional thoughts: Unlocking files in larger teams is likely something that should rather be possible by specific people, like a team lead who has access to the file anyways e.g. through sharing but also with groupfolders.

I could imagine that we just add a force unlock method for:

  • The file owner
  • Users who have permissions to manage ACL on groupfolders
  • A allow list for a dedicated group of users who are considered to be allowed to manually remove a lock

Might be much more useful than a real admin UI to enter the file id (which is something that an occ command can already do).

juliusknorr avatar May 06 '22 11:05 juliusknorr

I like the sketched out approach and agree this being an easier to use and apply solution also from a customer's organization perspective

AndyScherzinger avatar May 07 '22 11:05 AndyScherzinger

@jancborchardt Frontend wise shall we just make this the same unlock menu entry or an additional one e.g. saying "Force unlock"?

juliusknorr avatar Dec 28 '23 11:12 juliusknorr

@juliushaertl for simplicity it's best to do the same entry, yep.

jancborchardt avatar Dec 28 '23 12:12 jancborchardt