files_downloadactivity icon indicating copy to clipboard operation
files_downloadactivity copied to clipboard

When will Nextcloud 27 and 28 support be added?

Open arno4000 opened this issue 1 year ago • 10 comments

Steps to reproduce

  1. Install the app on Nextcloud 27
  2. Get the message Error: This app cannot be enabled because it makes the server unstable when enabling the app. When the app is enabled via occ app:enable files_downloadactivity, there is no error message.

Expected behaviour

The app should work on Nextcloud versions, which are not EOL in two months.

Actual behaviour

The app does not work in Nextcloud Versions which are newer than 26

arno4000 avatar Jan 22 '24 13:01 arno4000

+1

Sblop avatar Feb 13 '24 10:02 Sblop

Can we please get this just mainlined into nextCloud already? This really should be core functionality by default. Tracking activity across large nextCloud instances requires things like this.

BloodyIron avatar Feb 13 '24 17:02 BloodyIron

FYI: It works on NC 27 if you increase the max version in the info.xml of the app. But this is a hacky workaround which can potentially break at any time. It would be nice if the app would be updated before a new version of nextcloud is released.

arno4000 avatar Feb 14 '24 13:02 arno4000

There was probably a change in NC as well as my logs are splattered everywhere with "message":"Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"

immanuelfodor avatar Feb 19 '24 15:02 immanuelfodor

https://github.com/christian-baumann/files_downloadactivity/commit/a5f5f7a4fd101258da8563111c349ed3679162ce This file modification enables the application to be used on NC 28.0.3 RC1 👍

WechuTM avatar Feb 20 '24 10:02 WechuTM

There was probably a change in NC as well as my logs are splattered everywhere with "message":"Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"

Also reporting this, thousands of lines per day.

  "reqId": "lbOJJ5AsMSseYz5GZRDP",
  "level": 4,
  "time": "2024-02-29T23:13:52+11:00",
  "remoteAddr": "xxx.xxx.xxx.xxx",
  "user": "x",
  "app": "no app in context",
  "method": "GET",
  "url": "/apps/logreader/api/poll?lastReqId=xxx",
  "message": "Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36",
  "version": "28.0.3.2",
  "exception": {
    "Exception": "Error",
    "Message": "Call to undefined method OC\\Server::getEventDispatcher()",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Bootstrap/Coordinator.php",
        "line": 200,
        "function": "boot",
        "class": "OCA\\FilesDownloadActivity\\AppInfo\\Application",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/App/AppManager.php",
        "line": 434,
        "function": "bootApp",
        "class": "OC\\AppFramework\\Bootstrap\\Coordinator",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/App/AppManager.php",
        "line": 213,
        "function": "loadApp",
        "class": "OC\\App\\AppManager",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_App.php",
        "line": 125,
        "function": "loadApps",
        "class": "OC\\App\\AppManager",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/base.php",
        "line": 1049,
        "function": "loadApps",
        "class": "OC_App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/index.php",
        "line": 39,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/var/www/nextcloud/apps/files_downloadactivity/lib/AppInfo/Application.php",
    "Line": 49,
    "message": "Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()",
    "exception": [],
    "CustomMessage": "Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"
  },
  "id": "xxx"
}

nooblag avatar Feb 29 '24 12:02 nooblag

There was probably a change in NC as well as my logs are splattered everywhere with "message":"Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"

Also reporting this, thousands of lines per day.

Make the modifications described in the post https://github.com/christian-baumann/files_downloadactivity/commit/a5f5f7a4fd101258da8563111c349ed3679162ce should remove the error

WechuTM avatar Feb 29 '24 15:02 WechuTM

Thanks for that. I'd prefer an update released though, not too comfortable modifying files. Also, it'd be great if this app was made redundant anyways by mainlining like @BloodyIron suggested :) Would love that

nooblag avatar Mar 02 '24 11:03 nooblag

Yeah I literally need this functionality at this time (this week and going forward) for determining if my clients are downloading things I'm sharing with them. Right now I'm not sure if I can tell at all. And with this falling to the wayside for development, it really should be mainlined so it can get love when it needs it. Are there roadblocks or something?

BloodyIron avatar Mar 08 '24 17:03 BloodyIron

Title should be updated to include NC 29.0.0 :P

sephentos avatar May 05 '24 03:05 sephentos

For everyone, the app needs to be updated, sure, but you can force enable it. It works just fine :see_no_evil:

skjnldsv avatar Jul 31 '24 09:07 skjnldsv

Only the Call to undefined method OC\\Server::getEventDispatcher() :eyes:

skjnldsv avatar Jul 31 '24 09:07 skjnldsv

Fixed in upcoming release

skjnldsv avatar Jul 31 '24 10:07 skjnldsv

Yay! But will this ever be mainlined?

BloodyIron avatar Aug 02 '24 02:08 BloodyIron