files_downloadactivity icon indicating copy to clipboard operation
files_downloadactivity copied to clipboard

Files downloaded notification - when thumbnail is displayed in Recommended files on dashboard or in Files App when the contents of the folder are listed

Open aquananu opened this issue 2 years ago • 4 comments
trafficstars

see my request for this bug on snap nextcloud github page

https://github.com/nextcloud/server/issues/33687

ISSUE If we have shared any file via deck card or in talk, the icon of same is displayed in the recommended files app on the dashboard.

everytime a user logs on and the thumbnails are generated which is triggering the notification that the file was downloaded, whereas the user hasnt clicked on the file to download the same. This is generating a lot of notification and the useful ones are getting lost in the heap.

Also the thumbnails generated for the files list when the contents of the folder are displayed in the browser when using the files App.

The notification should not get triggered if the file is downloaded for creating icon to be displayed in the app dashboard or files App List

kindly change necessary code

aquananu avatar Jan 30 '23 07:01 aquananu

We only do this for previews which are bigger then 150px: https://github.com/nextcloud/files_downloadactivity/blob/master/lib/AppInfo/Application.php#L72 So I guess that's not it, unless the recommended files app is requesting much bigger previews than needed? But if you say sharing into Talk, that might be it. And then it's logging a download every time they open the Chat as there the preview is 384px IIRC. The problem is there are files where 384px are enough to give away all data and therefor it is exactly what the app is about and wants to do.

nickvergessen avatar Jan 30 '23 08:01 nickvergessen

hi nick appreciate your quick response on this matter, can this be made optional somehow so that we dont have notifications but the activity is logged with the name of the app that downloaded

aquananu avatar Jan 30 '23 10:01 aquananu

It's not downloaded by an app, but basically embedded there. But also in the hook where the activity is generated, we don't know where the request is coming from.

nickvergessen avatar Jan 30 '23 11:01 nickvergessen

thumbnail generator is part of nextcloud server or which app?? we can request thumbnail generator code to send one more variable that the file download is being request by the generator and the alert to be suppress

aquananu avatar Jan 30 '23 11:01 aquananu