external icon indicating copy to clipboard operation
external copied to clipboard

Navigation entry is missing required field `app`

Open susnux opened this issue 1 year ago • 2 comments

The navigation entry registration is missing the required app field (required since NC28):

https://github.com/nextcloud/external/blob/d9de3e5788651fce1f474cd72d874660fd6838d1/lib/AppInfo/Application.php#L76

There should be 'app' => 'external'.

susnux avatar Aug 27 '24 12:08 susnux

I wonder if this was done on purpose for some reason, @nickvergessen do you maybe remember? I haven't yet seen that this causes any problems.

provokateurin avatar Aug 27 '24 12:08 provokateurin

app field was not required/existing back then. Compared to the remaining 7yo code, the 10 months is the difference: https://github.com/nextcloud/server/blame/0a7fcde9069ff05cffe22e2ad6831d866103d12c/lib/private/NavigationManager.php#L377-L378

nickvergessen avatar Aug 27 '24 12:08 nickvergessen