Deleted files skip the trash bin when encryption is enabled

[nunesgh]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. Create a Text file, e.g. test.md.
2. Write anything within the file.
3. Delete the file.
4. Check the trash bin.

Expected behaviour

The deleted file should be in the trash bin.

Actual behaviour

The file is not there. It was completely deleted from my server.

Server configuration

Operating system: Debian 10

Web server: Apache 2

Database: MySQL

PHP version: 7.3

Nextcloud version: 19.0.3

Updated from an older Nextcloud/ownCloud or fresh install: Fresh install of Nextcloud 19.

Where did you install Nextcloud from: Website tarball.

Signing status:

Signing status

No errors have been found.

List of activated apps:

App list

Enabled:
  - accessibility: 1.5.0
  - activity: 2.12.0
  - admin_audit: 1.9.0
  - appointments: 1.7.7
  - apporder: 0.11.0
  - bruteforcesettings: 2.0.1
  - calendar: 2.0.4
  - cloud_federation_api: 1.2.0
  - comments: 1.9.0
  - contacts: 3.4.0
  - contactsinteraction: 1.0.0
  - dav: 1.15.0
  - deck: 1.1.0
  - encryption: 2.7.0
  - end_to_end_encryption: 1.5.2
  - federatedfilesharing: 1.9.0
  - federation: 1.9.0
  - files: 1.14.0
  - files_accesscontrol: 1.9.1
  - files_external: 1.10.0
  - files_pdfviewer: 1.8.0
  - files_rightclick: 0.16.0
  - files_sharing: 1.11.0
  - files_trashbin: 1.9.0
  - files_versions: 1.12.0
  - files_videoplayer: 1.8.0
  - firstrunwizard: 2.8.0
  - forms: 2.0.4
  - guests: 1.5.0
  - logreader: 2.4.0
  - lookup_server_connector: 1.7.0
  - news: 14.2.2
  - nextcloud_announcements: 1.8.0
  - notifications: 2.7.0
  - oauth2: 1.7.0
  - password_policy: 1.9.1
  - polls: 1.4.3
  - privacy: 1.3.0
  - provisioning_api: 1.9.0
  - quota_warning: 1.8.0
  - recommendations: 0.7.0
  - richdocuments: 3.7.4
  - serverinfo: 1.9.0
  - settings: 1.1.0
  - sharebymail: 1.9.0
  - spreed: 9.0.4
  - support: 1.2.1
  - survey_client: 1.7.0
  - systemtags: 1.9.0
  - tasks: 0.13.3
  - text: 3.0.1
  - theming: 1.10.0
  - twofactor_backupcodes: 1.8.0
  - twofactor_totp: 5.0.0
  - updatenotification: 1.9.0
  - viewer: 1.3.0
  - workflowengine: 2.1.0
Disabled:
  - photos
  - user_ldap

Nextcloud configuration:

Config report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "19.0.3.1",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "enable_previews": false,
        "filelocking.enabled": true,
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "default_language": "en",
        "default_locale": "en_AU",
        "defaultapp": "files",
        "skeletondirectory": "",
        "maintenance": false,
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "admin"
        ],
        "twofactor_enforced_excluded_groups": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "ssl",
        "mail_smtpport": "465",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "theme": "",
        "loglevel": 2,
        "trashbin_retention_obligation": "auto",
        "versions_retention_obligation": "auto"
    }
}

Are you using external storage, if yes which one: WebDAV

Are you using encryption: Yes.

Are you using an external user-backend, if yes which one: No.

Client configuration

Browser: Firefox 81.0

Operating system: Linux Mint 20

Logs

I was monitoring all the requested logs while performing the tests. The web server and the Nextcloud logs were not updated. The browser log was reporting some deprecation, including: moment, jQuery, registerTabView, and Legacy tabs.

[solracsf]

Following https://github.com/nextcloud/server/pull/21658 and https://github.com/nextcloud/server/pull/23023 i believe your trashbin has no default size set?

./occ trashbin:size -- -1 can set the default size to (50% of available space)

[nunesgh]

@acsfer thank you for your reply!

I have tried running the command as you suggested, but I always receive the same message and nothing changes:

Warning: changing the default trashbin size will automatically trigger cleanup of existing trashbins, a users trashbin can exceed the configured size until they move a new file to the trashbin.

Also, I was unable to find this command documented anywhere other than those merge requests you mentioned.

Running ./occ trashbin:size --output returns the following:

• global_size: default
• user_sizes:

[nunesgh]

@acsfer, by running ./occ trashbin:size, the command returns the current trashbin size.

Here is the output from my server:

Default size: default (50% of available space)

No per-user sizes configured

So there must be something else going on here, because the issue persists.

[nunesgh]

The issue persists on Nextcloud version 19.0.4.

Also, deleted files are skipping the trash bin not only on the server, but also on the desktop if they get deleted from either the web interface or the Android Nextcloud app.

Interestingly, the issue does not happen on the server if I delete a folder instead of a file.

[nunesgh]

@acsfer, do you know how Nextcloud manages to calculate the maximum available space?

According to this section and this section of the Nextcloud 19 documentation, it is expected that files would be automatically deleted if there is not enough space available. So, maybe my Nextcloud instance is not really aware of the available space and files are being permanently deleted once sent to the trash bin because the 50% threshold is always reached. Does it make any sense to you?

[nunesgh]

I think I was wrong. I've change the 'trashbin_retention_obligation' parameter to disabled and reloaded Apache, but the issue persists.

Also, I've noticed the Versions app is not working properly either, even though it is explicitly set to auto in the 'versions_retention_obligation' parameter.

[nunesgh]

@acsfer, if I disable server-side encryption then the issue is over. Disabling only the home storage encryption is not enough, though. So the issue is definitely related to the default encryption module.

[solracsf]

@nextcloud/encryption

[yahesh]

@nunesgh Do you create the file in a shared folder that is not owned by the user that deletes the file? If this is the case then this issue might be related with nextcloud/server#16419. Did you have a look into the data directory to check if there are really no files contained in the corresponding files_trashbin folder?

Additional question: Could you check what happens when you add the following value to your config.php: 'encryption_skip_signature_check' => true,? Does this fix the issue for you?

[nunesgh]

Hi @yahesh! Thank you for your reply!

Do you create the file in a shared folder that is not owned by the user that deletes the file?

No. Also, I'm the only user in this server.

Did you have a look into the data directory to check if there are really no files contained in the corresponding files_trashbin folder?

Yes, the files are completely gone.

Could you check what happens when you add the following value to your config.php: 'encryption_skip_signature_check' => true,? Does this fix the issue for you?

I will test and report back ASAP.

[nunesgh]

Additional question: Could you check what happens when you add the following value to your config.php: 'encryption_skip_signature_check' => true,? Does this fix the issue for you?

@yahesh, I'm unable to test this. I've tried to re-enable encryption but it does not work anymore --files do not get encrypted or do not finish syncing.

Actually, not even E2EE is working anymore. Files do not finish syncing and the following errors appear on the logs:

Errors

{"reqId":"ug9b2egSrcMtnuPIP8kj","level":1,"time":"2020-10-28T15:46:22+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"no app in context","method":"PROPFIND","url":"/remote.php/webdav/.Contacts-Backup","message":"Deprecated event type for {\"[object] (OCP\\SabrePluginEvent)\":{\"*statusCode\":200,\"*message\":\"\",\"*server\":{\"[object] (OCA\\DAV\\Connector\\Sabre\\Server)\":{\"tree\":\"[object] (OCA\\DAV\\Connector\\Sabre\\ObjectTree)\",\"*baseUri\":\"/remote.php/webdav/\",\"httpResponse\":\"[object] (Sabre\\HTTP\\Response)\",\"httpRequest\":\"[object] (Sabre\\HTTP\\Request)\",\"sapi\":\"[object] (Sabre\\HTTP\\Sapi)\",\"*plugins\":[],\"transactionType\":null,\"protectedProperties\":{\"...\":\"Over 20 items, aborting normalization\"},\"debugExceptions\":false,\"resourceTypeMapping\":[],\"enablePropfindDepthInfinity\":true,\"xml\":\"[object] (Sabre\\DAV\\Xml\\Service)\",\"*listeners\":{\"...\":\"Over 20 items, aborting normalization\"},\"*wildcardListeners\":[],\"*listenerIndex\":[],\"*logger\":null}},\"Symfony\\Contracts\\EventDispatcher\\EventpropagationStopped\":false}}: null","userAgent":"Mozilla/5.0 (Linux) mirall/3.0.2-20200924.150911.068ad89d8-1.0~focal1 (Nextcloud)","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

{"reqId":"glWmW9I0nL1LcT1Qofgd","level":3,"time":"2020-10-28T15:46:48+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"PHP","method":"GET","url":"/ocs/v1.php/cloud/user?format=json","message":{"Exception":"Error","Message":"Undefined offset: 3 at /***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/legacy/OC_Helper.php#548","Code":0,"Trace":[{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/legacy/OC_Helper.php","line":548,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::","args":[8,"Undefined offset: 3","/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/legacy/OC_Helper.php",548,{"path":"/","rootInfo":{"__class__":"OC\\Files\\FileInfo"},"includeExtStorage":false,"used":32,"quota":-3,"mount":{"__class__":"OC\\Files\\Mount\\MountPoint"},"storage":{"mountPoint":"/***REMOVED SENSITIVE VALUE***/","cache":null,"scanner":{"__class__":"OC\\Files\\Cache\\Scanner"},"watcher":null,"propagator":null,"updater":null,"__class__":"OCA\\FilesAccessControl\\StorageWrapper"},"sourceStorage":{"mountPoint":"/***REMOVED SENSITIVE VALUE***/","cache":null,"scanner":{"__class__":"OC\\Files\\Cache\\Scanner"},"watcher":null,"propagator":null,"updater":null,"__class__":"OCA\\FilesAccessControl\\StorageWrapper"},"free":30898569216,"total":30898569248,"relative":0,"ownerId":"***REMOVED SENSITIVE VALUE***","ownerDisplayName":"***REMOVED SENSITIVE VALUE***","owner":{"__class__":"OC\\User\\User"}}]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/apps/provisioning_api/lib/Controller/AUserData.php","line":190,"function":"getStorageInfo","class":"OC_Helper","type":"::","args":["/"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/apps/provisioning_api/lib/Controller/AUserData.php","line":137,"function":"fillStorageInfo","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->","args":["***REMOVED SENSITIVE VALUE***"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/apps/provisioning_api/lib/Controller/UsersController.php","line":414,"function":"getUserData","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->","args":["***REMOVED SENSITIVE VALUE***"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":169,"function":"getCurrentUser","class":"OCA\\Provisioning_API\\Controller\\UsersController","type":"->","args":[]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":100,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Provisioning_API\\Controller\\UsersController"},"getCurrentUser"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/AppFramework/App.php","line":152,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Provisioning_API\\Controller\\UsersController"},"getCurrentUser"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/Route/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Provisioning_API\\Controller\\UsersController","getCurrentUser",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"action":null,"_route":"ocs.provisioning_api.Users.getCurrentUser"}]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/ocs/v1.php","line":88,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/cloud/user"]}],"File":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/Log/ErrorHandler.php","Line":91,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Linux) mirall/3.0.2-20200924.150911.068ad89d8-1.0~focal1 (Nextcloud)","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

Is there any hope left for this server installation?

[nunesgh]

It seems I was able to fix E2EE. Even though I had already disabled everything related to encryption, I found by running sudo -u www-data php occ config:list that the encryption app was still storing information on keys that no longer existed, so I deleted those entries.

In any case, the server is logging a lot of errors all the time, including:

Errors

{"reqId":"JMzPdaVsiQxG0Oz3Ycrx","level":1,"time":"2020-10-28T23:46:09+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"no app in context","method":"GET","url":"/apps/files_trashbin/preview?fileId=3735&file=Testing.md%2FTesting.md.d1603928764&c=1603928764","message":"Deprecated event type for OCP\\IPreview:PreviewRequested: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

{"reqId":"0fuS3bYPdMOjrjrzzS8V","level":1,"time":"2020-10-28T23:46:11+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"no app in context","method":"PROPFIND","url":"/remote.php/webdav","message":"Deprecated event type for {\"[object] (OCP\\SabrePluginEvent)\":{\"*statusCode\":200,\"*message\":\"\",\"*server\":{\"[object] (OCA\\DAV\\Connector\\Sabre\\Server)\":{\"tree\":\"[object] (OCA\\DAV\\Connector\\Sabre\\ObjectTree)\",\"*baseUri\":\"/remote.php/webdav/\",\"httpResponse\":\"[object] (Sabre\\HTTP\\Response)\",\"httpRequest\":\"[object] (Sabre\\HTTP\\Request)\",\"sapi\":\"[object] (Sabre\\HTTP\\Sapi)\",\"*plugins\":[],\"transactionType\":null,\"protectedProperties\":{\"...\":\"Over 20 items, aborting normalization\"},\"debugExceptions\":false,\"resourceTypeMapping\":[],\"enablePropfindDepthInfinity\":true,\"xml\":\"[object] (Sabre\\DAV\\Xml\\Service)\",\"*listeners\":{\"...\":\"Over 20 items, aborting normalization\"},\"*wildcardListeners\":[],\"*listenerIndex\":[],\"*logger\":null}},\"Symfony\\Contracts\\EventDispatcher\\EventpropagationStopped\":false}}: null","userAgent":"Mozilla/5.0 (Linux) mirall/3.0.2-20200924.150911.068ad89d8-1.0~focal1 (Nextcloud)","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

{"reqId":"7moI7ZvGJJwAsyu6aDxC","level":3,"time":"2020-10-28T23:46:19+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"PHP","method":"GET","url":"/index.php/apps/files/ajax/getstoragestats.php?dir=%2F","message":{"Exception":"Error","Message":"Undefined offset: 3 at /***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/legacy/OC_Helper.php#548","Code":0,"Trace":[{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/legacy/OC_Helper.php","line":548,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::","args":[8,"Undefined offset: 3","/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/legacy/OC_Helper.php",548,{"path":"/","rootInfo":{"__class__":"OC\\Files\\FileInfo"},"includeExtStorage":false,"used":2598393,"quota":-3,"mount":{"__class__":"OC\\Files\\Mount\\MountPoint"},"storage":{"mountPoint":"/***REMOVED SENSITIVE VALUE***/","cache":null,"scanner":{"__class__":"OC\\Files\\Cache\\Scanner"},"watcher":null,"propagator":null,"updater":null,"__class__":"OCA\\FilesAccessControl\\StorageWrapper"},"sourceStorage":{"mountPoint":"/***REMOVED SENSITIVE VALUE***/","cache":null,"scanner":{"__class__":"OC\\Files\\Cache\\Scanner"},"watcher":null,"propagator":null,"updater":null,"__class__":"OCA\\FilesAccessControl\\StorageWrapper"},"free":30880141312,"total":30882739705,"relative":0.01,"ownerId":"***REMOVED SENSITIVE VALUE***","ownerDisplayName":"***REMOVED SENSITIVE VALUE***","owner":{"__class__":"OC\\User\\User"}}]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/apps/files/lib/Helper.php","line":51,"function":"getStorageInfo","class":"OC_Helper","type":"::","args":["/"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/apps/files/lib/Controller/AjaxController.php","line":47,"function":"buildFileStorageStatistics","class":"OCA\\Files\\Helper","type":"::","args":["/"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":169,"function":"getStorageStats","class":"OCA\\Files\\Controller\\AjaxController","type":"->","args":["/"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":100,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\AjaxController"},"getStorageStats"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/AppFramework/App.php","line":152,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files\\Controller\\AjaxController"},"getStorageStats"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/Route/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files\\Controller\\AjaxController","getStorageStats",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"action":null,"_route":"files.ajax.getStorageStats"}]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/base.php","line":1009,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/files/ajax/getstoragestats.php"]},{"file":"/***REMOVED SENSITIVE VALUE***/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/***REMOVED SENSITIVE VALUE***/nextcloud/lib/private/Log/ErrorHandler.php","Line":91,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

To be honest, I gave up on trying to make the encryption app to work. Having E2EE working, all I want right now is to fix the errors mentioned above without reinstalling the Nextcloud from scratch. Is that possible?

[yahesh]

@nunesgh It depends on how you disabled the server side encryption. Did you use ./occ encryption:decrypt-all at some point or are all the files on your disk still encrypted? What happened to the encrypted files? Are they still stored in your data folder or are they already gone?

If you properly deactivated the server side encryption before, you could try to cleanup the oc_filecache table. I'd start with a call to ./occ files:cleanup to delete invalid items from the filecache table and then do a ./occ files:scan to add yet unknown files to the filecache table.

P.S.: Please keep in mind that you could severely screw up your files if you did not properly disable the server side encryption before. It is known that ./occ files:scan may break entries in the filecache table when the server side encryption is enabled.

[nunesgh]

@yahesh, thank you for your reply!

I did run ./occ encryption:decrypt-all and manually checked whether the files could be read directly in the server. So currently all of my files are decrypted --except for one that is E2EE, which I used to test whether this feature was properly working again.

I do not have many files stored on my server. Running sudo -u www-data php occ files:scan --all returns a total of 11 folders and 9 files only (actually I have 3 folders and 8 files stored on the server). Also, running sudo -u www-data php occ files:scan-app-data returns 152 folders and 92 files.

No files are missing, the trash bin and versions apps seem to be working as intended (except for E2EE files, which I assume is expected), but the encryption app is now disabled.

Unfortunately, the same errors I reported yesterday persist and the server log is full of them. I have already tried all the documented commands that make sense for maintenance, db, and files, as listed here, but nothing has changed.

[yahesh]

The error messages that are left do not seem to be related to the server side encryption, but, given the provided logs, rather seem to be related with a SabreDAV mountpoint problem.

[nunesgh]

The following issue will be fixed with v20.0.2, according to https://github.com/nextcloud/server/issues/23595#issuecomment-717134843.

[PHP] Error: Error: Undefined offset: 3 at /var/www/nextcloud/lib/private/legacy/OC_Helper.php#548

But I have no idea about the other issues. I have even removed my external storage to check whether it was the source of problem, but the errors persist.

[skjnldsv]

Yes, that is an old issue https://github.com/nextcloud/server/issues/13759

[nunesgh]

Thank you for pointing that out, @skjnldsv!

I have already disabled the encryption app on my server, since the threat model does not benefit my use case. So now I only have the new E2EE app enabled.

Unfortunately, several errors continue to appear on my server's log, including the following ones:

Errors (formatted)

[no app in context] Info: Deprecated event type for OCP\IDBConnection::CHECK_MISSING_COLUMNS: Symfony\Component\EventDispatcher\GenericEvent is used

GET /settings/ajax/checksetup
from ***REMOVED SENSITIVE VALUE*** by ***REMOVED SENSITIVE VALUE*** at 2020-11-08T16:24:35+00:00

[no app in context] Info: Deprecated event type for OCP\IDBConnection::CHECK_MISSING_INDEXES: Symfony\Component\EventDispatcher\GenericEvent is used

GET /settings/ajax/checksetup
from ***REMOVED SENSITIVE VALUE*** by ***REMOVED SENSITIVE VALUE*** at 2020-11-08T16:24:34+00:00

[no app in context] Info: Deprecated event type for {"[object] (OCP\SabrePluginEvent)":{"*statusCode":200,"*message":"","*server":{"[object] (OCA\DAV\Connector\Sabre\Server)":{"tree":"[object] (OCA\DAV\Connector\Sabre\ObjectTree)","*baseUri":"/remote.php/webdav/","httpResponse":"[object] (Sabre\HTTP\Response)","httpRequest":"[object] (Sabre\HTTP\Request)","sapi":"[object] (Sabre\HTTP\Sapi)","*plugins":[],"transactionType":null,"protectedProperties":{"...":"Over 20 items, aborting normalization"},"debugExceptions":false,"resourceTypeMapping":[],"enablePropfindDepthInfinity":true,"xml":"[object] (Sabre\DAV\Xml\Service)","*listeners":{"...":"Over 20 items, aborting normalization"},"*wildcardListeners":[],"*listenerIndex":[],"*logger":null}},"Symfony\Contracts\EventDispatcher\EventpropagationStopped":false}}: null

PROPFIND /remote.php/webdav
from ***REMOVED SENSITIVE VALUE*** by ***REMOVED SENSITIVE VALUE*** at 2020-11-08T16:24:35+00:00

Errors (raw)

{"reqId":"aKegWomMTVMQJD5YGrCV","level":1,"time":"2020-11-08T16:24:35+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"no app in context","method":"GET","url":"/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_COLUMNS: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

{"reqId":"aKegWomMTVMQJD5YGrCV","level":1,"time":"2020-11-08T16:24:34+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"no app in context","method":"GET","url":"/settings/ajax/checksetup","message":"Deprecated event type for OCP\\IDBConnection::CHECK_MISSING_INDEXES: Symfony\\Component\\EventDispatcher\\GenericEvent is used","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

{"reqId":"TrzODjqXgsRTO9UtWp4v","level":1,"time":"2020-11-08T16:24:35+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"***REMOVED SENSITIVE VALUE***","app":"no app in context","method":"PROPFIND","url":"/remote.php/webdav","message":"Deprecated event type for {\"[object] (OCP\\SabrePluginEvent)\":{\"*statusCode\":200,\"*message\":\"\",\"*server\":{\"[object] (OCA\\DAV\\Connector\\Sabre\\Server)\":{\"tree\":\"[object] (OCA\\DAV\\Connector\\Sabre\\ObjectTree)\",\"*baseUri\":\"/remote.php/webdav/\",\"httpResponse\":\"[object] (Sabre\\HTTP\\Response)\",\"httpRequest\":\"[object] (Sabre\\HTTP\\Request)\",\"sapi\":\"[object] (Sabre\\HTTP\\Sapi)\",\"*plugins\":[],\"transactionType\":null,\"protectedProperties\":{\"...\":\"Over 20 items, aborting normalization\"},\"debugExceptions\":false,\"resourceTypeMapping\":[],\"enablePropfindDepthInfinity\":true,\"xml\":\"[object] (Sabre\\DAV\\Xml\\Service)\",\"*listeners\":{\"...\":\"Over 20 items, aborting normalization\"},\"*wildcardListeners\":[],\"*listenerIndex\":[],\"*logger\":null}},\"Symfony\\Contracts\\EventDispatcher\\EventpropagationStopped\":false}}: null","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0","version":"20.0.1.1","id":"***REMOVED SENSITIVE VALUE***"}

What can I do about those issues? Would reinstalling my server from scratch be the only option left?

[skjnldsv]

What can I do about those issues? Would reinstalling my server from scratch be the only option left?

Those are warning, not errors. I'll suggest you set your loglevel to 2 for production. Everything is working with those warnings :)

[nunesgh]

Awesome! Thank you, @skjnldsv!

[AMDBartek]

This issue is still happening for me with the Nextcloud 20.0.7.1 snap.

As stated in the issue when deleting files they bypass the trash bin but when deleting a folder it works and the folder shows in the trash bin.

Edit: Disabling E2EE (the app on the server) fixes the issue.

[irdet2]

I am also seeing this problem on version 21.0.1

[szaimen]

Is everyone here able to solve this issue by disabling the E2EE app?

[irdet2]

I was! At the time I have tested this disabling the E2EE solved this problem for me.

[kongomongo]

sorry but "Deleted files skip the trash bin when encryption is enabled", isn't that by design?

List of activated apps:
App list
end_to_end_encryption: 1.5.2

https://nextcloud.com/endtoend/ Accepted feature loss ... Server-side trash bin

[Mastertomspirit]

Yeah, it seems so.. Without E2E the trashbin app works fine.. 👍

[joshtrichards]

If a file is in a folder that is client-side encrypted (E2EE) than it bypasses the trashbin:

https://github.com/nextcloud/end_to_end_encryption/blob/7135af69a4a44be5f90ddeeba7ea20fd90893dbc/lib/AppInfo/Application.php#L92-L100

That's by design from all indications.

Part of the confusion I see in this thread may have arisen because both server-side and client-side encryption was enabled at the onset. That's not supported. Part of the reason I believe is that they both use the encrypted column to indicate a file is encrypted.

https://github.com/nextcloud/server/blob/9de8e8e2244cfbed63f9c4d4b8abdd6092fa848c/lib/private/Files/Cache/CacheEntry.php#L112-L114

https://github.com/nextcloud/end_to_end_encryption/blob/7135af69a4a44be5f90ddeeba7ea20fd90893dbc/lib/EncryptionManager.php#L68-L72

The net result is - I suspect - that if both server-side and client-side modes are enabled, the listener for moveToTrash (that is created by the the end_to_end_encryption app) will match every file on the server - even those just server-side encrypted.

This isn't a bug per se. It's documented that both forms of encryption should not be used together. This is just one of the side effects of ignoring that. :-)