documentation
documentation copied to clipboard
Fix traefik v1 example
We need to escape $ char in traefik v1 label otherwise this error occurs:
ERROR: Invalid interpolation format for "labels" option in service "web": "https://$1/remote.php/dav/"
cc @mrtumnus @pauvos what do you think?
I can't speak to the docker tag example, only to the toml portion. Assuming the intent of the "?:" is to prevent regex capture of the "(cal|card)" group, looks good to me.
Assuming the intent of the "?:" is to prevent regex capture of the "(cal|card)" group, looks good to me.
Yeah ?: makes it a non capturing group.
/rebase
Thanks :+1:
@szaimen can you merge this one? I guess it's fine to ignore the missing build.
Hello, Thank you all for you feedbacks. I removed trailing slash, added traefik v2 Docker label example and homogenized the examples.
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Sorry it took so long :see_no_evil:
/backport to stable25
Don't worry about it. Thank you for this merge @kesselb