documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Fix traefik v1 example

Open FlorentPoinsaut opened this issue 3 years ago • 7 comments

We need to escape $ char in traefik v1 label otherwise this error occurs: ERROR: Invalid interpolation format for "labels" option in service "web": "https://$1/remote.php/dav/"

FlorentPoinsaut avatar Jan 12 '22 07:01 FlorentPoinsaut

cc @mrtumnus @pauvos what do you think?

kesselb avatar Jun 12 '22 16:06 kesselb

I can't speak to the docker tag example, only to the toml portion. Assuming the intent of the "?:" is to prevent regex capture of the "(cal|card)" group, looks good to me.

mrtumnus avatar Jun 13 '22 13:06 mrtumnus

Assuming the intent of the "?:" is to prevent regex capture of the "(cal|card)" group, looks good to me.

Yeah ?: makes it a non capturing group.

kesselb avatar Jun 13 '22 16:06 kesselb

/rebase

kesselb avatar Jun 13 '22 16:06 kesselb

Thanks :+1:

kesselb avatar Jun 13 '22 18:06 kesselb

@szaimen can you merge this one? I guess it's fine to ignore the missing build.

kesselb avatar Jun 13 '22 18:06 kesselb

Hello, Thank you all for you feedbacks. I removed trailing slash, added traefik v2 Docker label example and homogenized the examples.

FlorentPoinsaut avatar Jun 14 '22 07:06 FlorentPoinsaut

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

welcome[bot] avatar Dec 17 '22 16:12 welcome[bot]

Sorry it took so long :see_no_evil:

kesselb avatar Dec 17 '22 16:12 kesselb

/backport to stable25

kesselb avatar Dec 17 '22 16:12 kesselb

Don't worry about it. Thank you for this merge @kesselb

FlorentPoinsaut avatar Dec 19 '22 10:12 FlorentPoinsaut