documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Removed the duplicate extension "js" warning from the NGINX configuration

Open acataluddi opened this issue 1 year ago • 7 comments

The current NGINX configuration triggers the following warning

nginx: [warn] duplicate extension "js", content type: "text/javascript", previous content type: "application/javascript" in /etc/nginx/sites-enabled/www.example.com.conf:124

acataluddi avatar May 21 '23 15:05 acataluddi

Hi @susnux,

I've rebased the latest master to modernise the branch and highlight the actual code changes.

Kind regards,
Adriano

acataluddi avatar Jun 09 '23 15:06 acataluddi

the rebase went wrong unfortunately

ChristophWurst avatar Jun 15 '23 18:06 ChristophWurst

@acataluddi but before we can merge this you need to sign you commit.

(pull and git commit --amend -s)

susnux avatar Jun 15 '23 19:06 susnux

@acataluddi but before we can merge this you need to sign you commit.

Hi @susnux, done.

Kind regards, Adriano C.

acataluddi avatar Jun 17 '23 17:06 acataluddi

@nickvergessen you accidentally dropped the sign-off

ChristophWurst avatar Jun 26 '23 07:06 ChristophWurst

I used the Github button "Update branch". I don't think it removed anything, but it more was not sign-off-ed before.

nickvergessen avatar Jun 26 '23 07:06 nickvergessen

Hi @acataluddi - seems the signoff was dropped. Can you please checkout your branch, do a pull, rebase on current master and do git commit --amend -s?

miaulalala avatar Jan 15 '24 11:01 miaulalala

Hi @acataluddi - seems the signoff was dropped. Can you please checkout your branch, do a pull, rebase on current master and do git commit --amend -s?

Hi Anna,

I've signed off all the commits and pushed the branch for a second review.

Kind regards, Adriano C.

acataluddi avatar Apr 28 '24 11:04 acataluddi