docker icon indicating copy to clipboard operation
docker copied to clipboard
verified publisher icon nextcloud

Add support for AWS Session Token configuration

Open refucktor opened this issue 10 months ago • 3 comments

Summary

  • Introduced logic to handle S3 session token using environment variables.
  • Supports session token from both a file and direct environment variable.
  • Defaults to an empty token if no value is provided.

refucktor avatar Feb 06 '25 15:02 refucktor

Thanks, @refucktor. Will take a closer look when the upstream support is added.

May also require some special handling if the upstream support is considered a feature and doesn't get backported to all of the major versions we support.

One bit of immediate feedback: this PR needs docs (entry in the appropriate section of the repo README).

P.S. Ping this PR one of us doesn't get around to re-looking at this PR after upstream is merged.

joshtrichards avatar Feb 06 '25 16:02 joshtrichards

hey @joshtrichards I received a notification that the PR in the 'server' repo has been merged. I guess we are getting closer to merge this one

refucktor avatar Mar 06 '25 14:03 refucktor

Indeed. Looks like it'll be in v32 (since it's a new feature).

I'm still not sure how to best handle the .config/ variant since it'll only apply to v32 and not our other image versions.

We could just document the variable as >=v32 only.... or we could enhance update.sh to also handle different config files across variants? I kind of lean towards the former since this rarely comes up...

@J0WI Thoughts?

joshtrichards avatar Mar 06 '25 15:03 joshtrichards