docker icon indicating copy to clipboard operation
docker copied to clipboard

Adding support for DBINDEX redis config value in docker compose

Open GroondCharge opened this issue 1 year ago • 7 comments

Currently, there is no support for adding dbindex config value ($CONFIG['redis']['dbindex']) within compose file. Even in manually updating or setting the value for a container, the changes aren't applied. This fixes the missing option.

GroondCharge avatar Sep 02 '24 09:09 GroondCharge

Please see:

#2236 #1286

I'm not 100% against this, but the session handler needs to be considered too. It's not clear what the "right thing to do here is".

Personally I'd just avoid dbindex and use dedicated Redis. This is a container environment after all. :-)

joshtrichards avatar Sep 02 '24 17:09 joshtrichards

Please see:

#2236 #1286

I'm not 100% against this, but the session handler needs to be considered too. It's not clear what the "right thing to do here is".

Personally I'd just avoid dbindex and use dedicated Redis. This is a container environment after all. :-)

https://github.com/nextcloud/docker/pull/1286#issuecomment-1797020464 this becomes a hassle especially, when one'd try to automate deployment. It feels like this would be a nice feature to have available if needed irregardless if it's not optimal for 90% of the cases. However! There is a middle ground imo - prefixes. This would work if you had a redis instance that's running for multiple services or even, if there are multiple NCs connecting to a redis cluster

GroondCharge avatar Sep 03 '24 05:09 GroondCharge

According to this: https://github.com/nextcloud/server/issues/32203 the prefix for nextcloud is calculated, but then changes when either path, version and/or instanceid would change. If there was a way to make prefix optionally persistent, then these issues would be solved.

GroondCharge avatar Sep 03 '24 07:09 GroondCharge

Hi, maybe this helps as reference? https://github.com/nextcloud/all-in-one/pull/5126

szaimen avatar Sep 04 '24 15:09 szaimen

Hi, maybe this helps as reference? nextcloud/all-in-one#5126

Thank you for this, i changed it to configure session locking appropriately, aswell as name for env variable, to match the ones you used

GroondCharge avatar Sep 05 '24 07:09 GroondCharge

Needs rebase. Please only change the templates and .config folder in the Git root. The files for the Nextcloud versions are just generated.

J0WI avatar Apr 18 '25 13:04 J0WI

Hello, any news from this PR?

nioc avatar May 08 '25 22:05 nioc