docker
docker copied to clipboard
replace build image with bind mount
A separate image is currently being built for the nginx proxy (service name: web). According to my information, this is not necessary, but even counterproductive
Why?
- The image does not need to be built (why should it?)
- Fewer files and less code = easier maintenance and fewer potential bugs
- the container can be easily updated (for example via a program like watchtower)
I agree here. I would also move the configuration file outside of the "web" directory or just rename the web directory to "conf" one. This has the good side effect that will allow using that same "conf" directory for other stuff, like mounting mime-types; Nextcloud's own configuration there in the case of bind mounts; proxy related configurations; even in my use case - Nexcloud's container configs like opcache-recommed.ini and similar.
EDIT: Docker on Windows now use WSL2, so no problems with #538 anymore. Also, the non-root nginx image is a very good idea as well.
Agreed 🙂
Readme needs to be updated as well. There is a similar patch in #1994.