docker icon indicating copy to clipboard operation
docker copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Added custom opcache config override

Open bronco0 opened this issue 1 year ago • 7 comments

Added the ability to customize PHP OPcache configuration. Default values ​​have been set to environment variables that can be overridden.

bronco0 avatar Aug 13 '24 09:08 bronco0

This adds a lot of new envs. Do you require all of them?

J0WI avatar Sep 18 '24 20:09 J0WI

I think it's a good idea to be able to customize any OPcache setting.

bronco0 avatar Sep 19 '24 07:09 bronco0

I'm a bit worried to add that many ENVs. I can imagine some cases where it's useful to adjust the numbers but why would you change opcache.save_comments or opcache.jit? IMHO ENVs should only exist for common use cases and everything else can still be configured by mounting additional config files into the container.

J0WI avatar Sep 22 '24 22:09 J0WI

@bronco0 are you still working on this?

J0WI avatar Jan 09 '25 22:01 J0WI

@J0WI As I'm interested in this as well and @bronco0 isn't responding I might take over this PR and fix the points you mention in your review.

pankrazv avatar Jan 14 '25 11:01 pankrazv

Sorry, I haven't had much time lately. I'll see about quickly modifying my PR.

@J0WI do we keep all these parameters or just some ?

bronco0 avatar Jan 14 '25 13:01 bronco0

do we keep all these parameters or just some ?

just some. Is this still relevant after #2090? Which one have a common use case?

J0WI avatar Jan 16 '25 23:01 J0WI