docker icon indicating copy to clipboard operation
docker copied to clipboard

Remove unecessary app logic (fix #1213)

Open J0WI opened this issue 1 year ago • 1 comments

Fix #1911

J0WI avatar Jul 20 '24 12:07 J0WI

Seems fine if this goes away since it was just a passive partial remedy. But perhaps we should create a follow-up issue?[^aio][^issue][^more]

This seems like something that needs to be nudged upstream to get addressed in Server itself rather than in the downstream images/packagers.

[^issue]: Basically to collect data on upgrade problems that are app related and to, maybe, evaluate what (if any) benefits there might be to taking AIO's approach (at least until any deemed appropriate upstream changes are made).

[^aio]: I'm not sure the root issue (of the upstream app update logic not always being robust enough) is fully addressed. AIO actually does more at this point (after originally doing what this PR removes).

[^more]: nextcloud/all-in-one#1420 AIO replaced the code under discussion in this PR with a broader scope improvement to make upgrades more robust in nextcloud/all-in-one#1400 / nextcloud/all-in-one#1420

joshtrichards avatar Jul 20 '24 16:07 joshtrichards