docker icon indicating copy to clipboard operation
docker copied to clipboard

use var PHP_OPCACHE_MEMORY_CONSUMPTION for configuration

Open tclavier opened this issue 1 year ago • 8 comments

tclavier avatar Oct 26 '23 09:10 tclavier

I think maybe using "sed" to change original files? https://github.com/nextcloud/docker/blob/master/27/fpm/Dockerfile#L99-L103

jjasoncool avatar Nov 29 '23 02:11 jjasoncool

using sed in startup script to replace opcache.memory_consumption=128 by opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION} ?

tclavier avatar Nov 29 '23 09:11 tclavier

using sed in startup script to replace opcache.memory_consumption=128 by opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION} ?

Sorry, That all version was build by template files, your code is right. But I think that can also add ENV jit_buffer_size also.

jjasoncool avatar Dec 17 '23 04:12 jjasoncool

This requires some documentation in the README.

J0WI avatar Jan 09 '24 22:01 J0WI

See also https://github.com/nextcloud/docker/pull/2185#issuecomment-2027362851

J0WI avatar Apr 02 '24 21:04 J0WI

This is a common request downstream in nextcloud/helm. If this PR was re-submitted with the suggested fixes here, would it still be viable? I see there was conversation #2185, but I can't tell if that means this PR should be closed?

jessebot avatar Jul 29 '24 10:07 jessebot