desktop icon indicating copy to clipboard operation
desktop copied to clipboard

[Bug]: Outside "Settings", some button iconography is absent.

Open RokeJulianLockhart opened this issue 1 year ago • 23 comments

Before submitting, please verify the following:

  1. [x] This is a bug, not a question or a configuration issue.

  2. [x] This issue is not already reported on Github (I've searched it).

  3. [x] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.

  4. [x] I agree to follow Nextcloud's Code of Conduct

Bug description

As the undermentioned screenshot demonstrates, the ~~toolbar~~ ^1 button iconography is absent:

  1. The Homepage

    org.kde.breezedark.desktop org.kde.breeze.desktop
    Image Image
  2. The Distribution Configuration Flyout

    org.kde.breezedark.desktop org.kde.breeze.desktop
    Image Image
  3. The Account Action Context Menu

    org.kde.breezedark.desktop org.kde.breeze.desktop
    Image Image

However, this doesn't affect the configuration window:

Image Image Image

This is a partial recurrence of issues/6594#issue-2213769118 - a regression.

Steps to reproduce

  1. Install nextcloud-client-3.14.2-1.fc42 (as a dependency of nextcloud-client-dolphin-3.14.2-1):

    #!/usr/bin/env sh
    sudo dnf install 'nextcloud-client-3.14.2-2.fc40.x86_64'
    
  2. Invoke the GUI:

    #!/usr/bin/env sh
    nextcloud-client
    

Expected behavior

The icons should be rendered.

Which files are affected by this bug

/usr/bin/nextcloud

Operating system

Linux

Which version of the operating system you are running.

Fedora-KDE-Live-x86_64-40-1.14.iso

Package

packages.fedoraproject.org/pkgs/nextcloud-client/nextcloud-client, via dnf5

Nextcloud Server version

28.0.10.1

Nextcloud Desktop Client version

  1. 3.14.2-1.fc42

  2. 3.16.3-2.fc42

Is this bug present after an update or on a fresh install?

I don't know, but I presume that it updated from a minor version (ex. 3.4.2 to 3.4.4).

Are you using the Nextcloud Server Encryption module?

I don't know.

Are you using an external user-backend?

I don't know.

RokeJulianLockhart avatar Oct 25 '24 17:10 RokeJulianLockhart

https://github.com/nextcloud/desktop/issues/7419#issue-2614702441

This affects more than merely toolbar button iconography, actually:

Image

RokeJulianLockhart avatar Oct 27 '24 02:10 RokeJulianLockhart

Note that also the following icons are not shown in when pressing the details button:

Image

Is this because there are no white/black themed variants of the svg files referenced?

the-nic avatar Oct 29 '24 09:10 the-nic

https://github.com/nextcloud/desktop/issues/7419#issuecomment-2443711356

@the-nic, are you able to provide environment information too? kinfo is usually enough.

Is this because there are no white/black themed variants of the svg files referenced?

I'd be surprised, since in examples like invent.kde.org/frameworks/breeze-icons/-/merge_requests/410#note_1054423, the application should fall back to Breeze's colourful icons.

~~Perhaps it's another example of gitlab.freedesktop.org/xdg/xdg-specs/-/issues/132, although that's merely a guess.~~

RokeJulianLockhart avatar Oct 29 '24 10:10 RokeJulianLockhart

kinfo data:

Operating System: Arch Linux 
KDE Plasma Version: 6.2.2
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0
Kernel Version: 6.6.58-1-lts (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 5800X 8-Core Processor
Memory: 31.2 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2

the-nic avatar Oct 29 '24 13:10 the-nic

I experience the same behaviour as @RokeJulianLockhart and @the-nic here with a different distribution (Tumbleweed). Just to add some context.

kinfo data:

Operating System: openSUSE Tumbleweed 20241027
KDE Plasma Version: 6.2.2
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0
Kernel Version: 6.11.5-1-default (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics

BatmansGehilfe avatar Oct 29 '24 16:10 BatmansGehilfe

Same or very similar issue on windows. Might be something about dark mode. Image

working-name avatar Nov 09 '24 16:11 working-name

https://github.com/nextcloud/desktop/issues/7419#issuecomment-2466272561

@working-name, thanks for that. It discounts the aforementioned:

Perhaps it's another example of gitlab.freedesktop.org/xdg/xdg-specs/-/issues/132, although that's merely a guess.

RokeJulianLockhart avatar Nov 09 '24 16:11 RokeJulianLockhart

I don't think it is about dark mode: I experience the same behaviour in "light mode".

Image

BatmansGehilfe avatar Nov 11 '24 11:11 BatmansGehilfe

https://github.com/nextcloud/desktop/issues/7419#issuecomment-2467985643

@BatmansGehilfe, I do too — the context menu icons don't even recolour:

Image Image

I've reported this at https://github.com/nextcloud/desktop/issues/8293#issue-3081278953.

RokeJulianLockhart avatar Nov 11 '24 13:11 RokeJulianLockhart

Same here:

Operating System: Fedora Linux 41 KDE Plasma Version: 6.3.1 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.12.15-200.fc41.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 PRO 6650U with Radeon Graphics Memory: 30.7 GiB of RAM Graphics Processor: AMD Radeon Graphics

avatar1024 avatar Feb 26 '25 18:02 avatar1024

I looked a bit at this issue today -- for some strange reason the icon.source property on AbstractButtons doesn't work with image:// URLs (used for QQuickImageProvider) on Linux. It's really strange that it's working fine on macOS and Windows though 🤔

nilsding avatar Feb 26 '25 18:02 nilsding

https://github.com/nextcloud/desktop/issues/7419#issuecomment-2685857864

@nilsding, if that's the problem, then that sounds like a QTBUG. I shan't be surprised if a relevant report exists at Jira, but I'm not proficient at searching it.

I'd say that the solution is as simple as just converting that URI to a path before it's passed to the provider, but the docs don't appear to demonstrate that that's permitted.

RokeJulianLockhart avatar Feb 26 '25 18:02 RokeJulianLockhart

after some more checks I think this is more an issue with the Breeze QQuick style rather than something inside Qt itself -- in fact there's already a bug report on the KDE bugzilla about icon.source not being handled in a way that QML usually does: https://bugs.kde.org/show_bug.cgi?id=433433

The AppImage builds we provide use the Fusion QQuick style, and it works fine there as well.

nilsding avatar Mar 22 '25 21:03 nilsding

https://github.com/nextcloud/desktop/issues/7419#issuecomment-2745794768

@nilsding, thanks. I've requested clarification at #c5, since that does appear plausible. I can try forcing Fusion on the RPM to confirm, if you provide the relevant CLI parameters or configuration file content.

RokeJulianLockhart avatar Mar 22 '25 22:03 RokeJulianLockhart

This problem remains on 3.16.3-2.fc42:

Image Image

However, the triage assignee for the aforecited KDE bug (id=433433) has tentatively confirmed that this appears to be a symptom of it. ~~Consequently, I believe that I should close this due to it being an upstream fault, unless anyone can confirm this on any DE other than KDE Plasma.~~

RokeJulianLockhart avatar May 21 '25 19:05 RokeJulianLockhart

The triage assignee for the aforecited KDE bug (id=433433) has tentatively confirmed that this appears to be a symptom of it. Consequently, I believe that I should close this due to it being an upstream fault, unless anyone can confirm this on any DE other than KDE Plasma.

In retrospect, I forgot https://github.com/nextcloud/desktop/issues/7419#issuecomment-2466272561. Can it be caused by KDE if it reproduces on Windows? I would presume not. I'll attempt to ascertain whether this might be better taken to Qt themselves.

RokeJulianLockhart avatar May 21 '25 19:05 RokeJulianLockhart

@RokeJulianLockhart we're using different QML styles on windows, and we had to fix a couple of dark mode-related issues for those.

All other QML styles we use display the icons just fine: FluentWinUI3, Universal, Fusion, and the standard macOS one.

nilsding avatar May 21 '25 19:05 nilsding

@RokeJulianLockhart the issue title change you did, is incorrect, the icons are missing elsewhere also (like dolphin right click nextcloud share menu), not only in home menu

Image

Running version nextcloud-client.x86_64 3.16.3-2.fc42

GameBurrow avatar May 27 '25 11:05 GameBurrow

@RokeJulianLockhart the issue title change you did, is incorrect, the icons are missing elsewhere also (like dolphin right click nextcloud share menu), not only in home menu

I can confirm this

major-mayer avatar May 27 '25 11:05 major-mayer

https://github.com/nextcloud/desktop/issues/7419#issuecomment-2912151292

@GameBurrow and @major-mayer, thanks. Added to the issue description.

RokeJulianLockhart avatar May 27 '25 14:05 RokeJulianLockhart

I have this issue too, it's been bugging me for many months, and it seems to be across different versions too.

Operating System: Debian GNU/Linux 12
KDE Plasma Version: 6.3.4
KDE Frameworks Version: 6.13.0
Qt Version: 6.8.2
Kernel Version: 6.12.27-amd64 (64-bit)
Graphics Platform: Wayland
Processors: 8 × 11th Gen Intel® Core™ i5-1135G7 @ 2.40GHz
Memory: 31.1 GiB of RAM
Graphics Processor: Intel® Iris® Xe Graphics

rsnyman avatar Jun 01 '25 03:06 rsnyman

I found that reverting 599bbbed2a3a0489c0acfdce2c98c6fa89a9eef0 adds the more-apps icon back into header menu

the-nic avatar Jun 01 '25 13:06 the-nic

still present in 3.16.4

poltpolt avatar Jun 03 '25 09:06 poltpolt

Still present in 3.16.6, see my comment on another issue for details.

lolcabanon avatar Jul 19 '25 04:07 lolcabanon

Still present in 3.17.0 (I'm still using openSUSE Tumbleweed, KDE Plasma 6.4.4)

BatmansGehilfe avatar Aug 21 '25 06:08 BatmansGehilfe

I'm using the Flatpak version and still seeing the issue with 3.17.1 on KDE Plasma 6.4.4 (Fedora 42)

Nextcloud Desktop Client Version 3.17.1daily (KDE)

Image

questionlp avatar Aug 21 '25 17:08 questionlp

In archlinux still persists. As a workaround one may use nextcloud-client-appimage-daily AUR package, but that is not a solution at all.

Mayurifag avatar Aug 31 '25 15:08 Mayurifag

unsure what the desktop client could do I use QT_QPA_PLATFORMTHEME=gtk3 ./nextcloud as a workaround my best guess is that this could be discussed with the KDE maintainers of the qml style I am closing it as I think at least for some of the visual bugs, we have no way to fix them (the double down arrow for example) I also acknowledge that this is a real issue (I am impacted)

mgallien avatar Sep 12 '25 11:09 mgallien

https://github.com/nextcloud/desktop/issues/7419#issuecomment-3284994975

@mgallien, I've asked at discuss.kde.org/t/39648. If anyone here is willing to register for KDE's Discourse instance, a like would help to ensure it becomes visible amongst the deluge of daily posts.

~~If anyone has significant reason to believe that this is a bug with the QQuickStyle, please file a bug at bugs.kde.org/enter_bug.cgi?product=frameworks-qqc2-desktop-style (or similar, if that component is incorrect), and link to it here, or at the cited Discourse thread.~~

RokeJulianLockhart avatar Sep 12 '25 12:09 RokeJulianLockhart

Since it does not seem this will be solved in the near future, forcing or defaulting to the GTK3 theme could be an appropriate temporary measure to avoid delivering a broken experience to users out of the box.

JSGRD22 avatar Sep 12 '25 14:09 JSGRD22