desktop
desktop copied to clipboard
Add a context menu for the sharees search field
Closes #6199
AppImage file: nextcloud-PR-7355-3f34805183fcbe63241ae9cff3ba905a11c0187b-x86_64.AppImage
To test this change/fix you can simply download above AppImage file and test it.
Please make sure to quit your existing Nextcloud app and backup your data.
@mgallien argh, I had not thought of that, thanks for bringing it up
are you aware of how we can detect this? I would rather not traverse the scene graph to check...
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@mgallien argh, I had not thought of that, thanks for bringing it up
are you aware of how we can detect this? I would rather not traverse the scene graph to check...
should we not check what is the QML style in use and enable or disable some of our added features ?
@mgallien argh, I had not thought of that, thanks for bringing it up are you aware of how we can detect this? I would rather not traverse the scene graph to check...
should we not check what is the QML style in use and enable or disable some of our added features ?
Okay, have implemented this
for some reason the suggestions popup also shows up along with the context menu when right-clicking on Win11 (after fixing the compilation as described below)
Screencast_20250314_090640.webm
I've added a call on aboutToShow that explicitly hides the suggestions popup if it's visible; does this fix the issue on Windows?
Artifact containing the AppImage: nextcloud-appimage-pr-7355.zip
SHA256 checksum: d582e1e9d968e30ba3d4073ab07c202b301cd4b51b3e177f15b0bf764661ad3a
To test this change/fix you can download the above artifact file, unzip it, and run it.
Please make sure to quit your existing Nextcloud app and backup your data.
I've added a call on aboutToShow that explicitly hides the suggestions popup if it's visible; does this fix the issue on Windows?
It's a bit better now with the z-index set, but it still appears when the TextField is focused sometimes:
Quality Gate failed
Failed conditions
E Maintainability Rating on New Code (required ≥ A)
13 New Code Smells (required ≤ 0)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
superseded by new features in Qt
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the blocklist.)